Skip to content

Commit ff5cb35

Browse files
committed
add e2e tests
1 parent 1a72224 commit ff5cb35

File tree

1 file changed

+7
-1
lines changed
  • vertical-pod-autoscaler/enhancements/8515-support-custom-request-to-limit-ratio

1 file changed

+7
-1
lines changed

vertical-pod-autoscaler/enhancements/8515-support-custom-request-to-limit-ratio/README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
- [When Disabled](#when-disabled)
2020
- [Kubernetes Version Compatibility](#kubernetes-version-compatibility)
2121
- [Test Plan](#test-plan)
22+
- [E2E](#e2e)
2223
- [Examples](#examples)
2324
- [Implementation History](#implementation-history)
2425
<!-- /toc -->
@@ -154,8 +155,13 @@ The behavior after implementing this feature is as follows:
154155
### Test Plan
155156

156157
* Implement comprehensive unit tests to cover all new functionality.
157-
* e2e tests: TODO
158158

159+
#### E2E
160+
161+
* e2e tests with `InPlaceOrRecreate` VPA mode:
162+
1. Add a test case where the QoS class **changes**. In this scenario, we expect the updater to evict the affected Pods, since the QoS field is immutable.
163+
2. Add a test case where the QoS class **does not change**. In this scenario the updater should apply the new ratio using the in-place update mechanism.
164+
* Add a test case to verify that when `RequestToLimitRatio` is specified for a container, the ratio from the Workload API (i.e. Deployment) is ignored and no longer considered.
159165

160166
### Examples
161167

0 commit comments

Comments
 (0)