From 02e2afabbfe7a899477b159de79b38b85dbbb0be Mon Sep 17 00:00:00 2001 From: Mahmoud Atwa Date: Tue, 5 Aug 2025 15:56:59 +0000 Subject: [PATCH] Fix CA's command --- cluster-autoscaler/Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cluster-autoscaler/Makefile b/cluster-autoscaler/Makefile index 663856747502..b88cd75288b4 100644 --- a/cluster-autoscaler/Makefile +++ b/cluster-autoscaler/Makefile @@ -1,6 +1,10 @@ ALL_ARCH = amd64 arm64 s390x all: $(addprefix build-arch-,$(ALL_ARCH)) +# TODO: #8127 - Use default analyzers set by `go test` to include `printf` analyzer. +# Default analyzers that go test runs according to https://github.com/golang/go/blob/52624e533fe52329da5ba6ebb9c37712048168e0/src/cmd/go/internal/test/test.go#L649 +# This doesn't include the `printf` analyzer until cluster-autoscaler libraries are updated. +GO_TEST_DEFAULT_ANALYZERS?=atomic,bool,buildtags,directive,errorsas,ifaceassert,nilfunc,slog,stringintconv,tests TAG?=dev FLAGS= LDFLAGS?=-s @@ -129,7 +133,7 @@ container-arch-%: build-in-docker-arch-% make-image-arch-% @echo "Full in-docker image ${TAG}${FOR_PROVIDER}-$* completed" test-in-docker: clean docker-builder - docker run ${RM_FLAG} -v `pwd`:/cluster-autoscaler/:Z autoscaling-builder:latest bash -c 'cd /cluster-autoscaler && go test -race ./... ${TAGS_FLAG}' + docker run ${RM_FLAG} -v `pwd`:/cluster-autoscaler/:Z autoscaling-builder:latest bash -c 'cd /cluster-autoscaler && go test -race ./... -vet="${GO_TEST_DEFAULT_ANALYZERS}" ${TAGS_FLAG}' .PHONY: all build test-unit clean format execute-release dev-release docker-builder build-in-docker release generate push-image push-manifest