Skip to content

CA: update k8s deps to 1.35.0-beta.0 #8827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

CA: update k8s deps to 1.35.0-beta.0 #8827

wants to merge 5 commits into from

Conversation

@jackfrancis
Copy link
Contributor

@jackfrancis jackfrancis commented Nov 19, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR brings in the 1.35 Kubernetes deps in preparation for a 1.35 release of CA.

Which issue(s) this PR fixes:

Fixes #8742

Special notes for your reviewer:

Does this PR introduce a user-facing change?

update k8s deps to 1.35.0-alpha.3

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Nov 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-area size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2025
@jackfrancis jackfrancis force-pushed the ca-1.35.0-alpha.3 branch 6 times, most recently from 2ece218 to 8d755e8 Compare November 19, 2025 18:56
@jackfrancis
Copy link
Contributor Author

jackfrancis commented Nov 19, 2025

@towca this PR aims to bring in the DeviceClassResolver addition w/ the 1.35 k8s dependencies

cc @gnufied you should be able to rebase your CSI changs on top of this (it will be better to have a discrete PR that brings in changes from updates to k8s dependencies)

@gnufied
Copy link
Member

gnufied commented Nov 19, 2025

That is fine. I will rebase.

jackfrancis
jackfrancis commented Nov 19, 2025
View reviewed changes
cluster-autoscaler/simulator/clustersnapshot/predicate/plugin_runner_test.go
assert.NotNil(t, predicateErr)
assert.Contains(t, predicateErr.FailingPredicateReasons(), "node(s) had untolerated taint {SomeTaint: WhyNot?}")
assert.Contains(t, predicateErr.Error(), "node(s) had untolerated taint {SomeTaint: WhyNot?}")
assert.Contains(t, predicateErr.FailingPredicateReasons(), "node(s) had untolerated taint(s)")
Copy link
Contributor Author

@jackfrancis jackfrancis Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

credit to @gnufied for saving me time having to figure out this one 🙏

@jackfrancis
Copy link
Contributor Author

jackfrancis commented Nov 19, 2025

/test pull-cluster-autoscaler-e2e-azure-master

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/provider/azure Issues or PRs related to azure provider labels Nov 19, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2025
@elmiko
Copy link
Contributor

elmiko commented Nov 19, 2025

looks like an error with a go.sum file, but the units are fine.

/retest

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 19, 2025
@gnufied
Copy link
Member

gnufied commented Nov 19, 2025

This PR appears to be pulling a version of kube-scheduler which is slightly older and I do not have CSI related stuff and hence I can't easily rebase. Is there any reason to rebase off alpha.3 rather than https://github.com/kubernetes/kube-scheduler/tree/v0.35.0-beta.0 which has all the stuff we need?

@gnufied
Copy link
Member

gnufied commented Nov 19, 2025 •
edited
Loading

heh, looks like .beta.0 was released just an hour ago. oh well nvm. But we will have to likely update dependencies again. :-)

On second thought - @jackfrancis would you mind rebasing this to .beta.0, now that it has been released?

@jackfrancis
Copy link
Contributor Author

jackfrancis commented Nov 20, 2025

@gnufied yes happy to use beta.0

@jackfrancis
Copy link
Contributor Author

jackfrancis commented Nov 20, 2025

/retest

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 20, 2025
@gnufied
Copy link
Member

gnufied commented Nov 20, 2025 •
edited
Loading

Just to give you heads up, if you do try and rebase with 0.beta, you may run into an issue because newer plugin expects a CSIManager to be initialized - https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/framework/plugins/nodevolumelimits/csi.go#L266 , this will fail with current autoscaler code because, we do not provide one.

I have fixed this in my PR - https://github.com/kubernetes/autoscaler/pull/8721/files#diff-0e72c9730865fb559aa73d9b93e514b54ff7baac7ce61b4e2ca73223e4311fb5R68 which initializes a CSImanager regardless if CSI limit awareness featuregate is enabled or disabled. My code basically provides a API lister based implementation if CSI limit awareness is not enabled in CAS but if it is enabled, it provides an implementation based on snapshot object.

@jackfrancis
Copy link
Contributor Author

jackfrancis commented Nov 20, 2025

@gnufied thank you!

I'm actually getting a different error using alpha.3:

F1120 02:18:28.891178       1 main.go:368] couldn't set the DRA feature gate to false: cannot set feature gate DynamicResourceAllocation to false, feature is locked to true

Ref: https://storage.googleapis.com/kubernetes-ci-logs/pr-logs/pull/autoscaler/8827/pull-cluster-autoscaler-e2e-azure-master/1991319108221669376/artifacts/clusters/capz-at3yno/default/cluster-autoscaler-azure-cluster-autoscaler-7dcc5c9464-bhpt8/azure-cluster-autoscaler.log

I'll go ahead and move to beta.0 and we can address breaking changes there.

@jackfrancis
Copy link
Contributor Author

jackfrancis commented Nov 20, 2025

/retitle CA: update k8s deps to 1.35.0-beta.0

@k8s-ci-robot k8s-ci-robot changed the title CA: update k8s deps to 1.35.0-alpha.3 CA: update k8s deps to 1.35.0-beta.0 Nov 20, 2025
@gnufied
Copy link
Member

gnufied commented Nov 20, 2025 •
edited
Loading

F1120 02:18:28.891178 1 main.go:368] couldn't set the DRA feature gate to false: cannot set feature gate DynamicResourceAllocation to false, feature is locked to true

Yep, we will have to either enable all those featuregates by default or fix corresponding jobs that depend on this. This feature can't be disabled anymore.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 20, 2025

@jackfrancis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-autoscaler-e2e-azure-master 52c809a link false /test pull-cluster-autoscaler-e2e-azure-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@vadasambar vadasambar Awaiting requested review from vadasambar

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CA DRA: implement DeviceClassResolver()

4 participants

@jackfrancis @k8s-ci-robot @gnufied @elmiko