Skip to content

Commit ffbb4b8

Browse files
committed
Add test to confirm dual stack can't be on CLBs
Signed-off-by: Nolan Brubaker <[email protected]>
1 parent 70fa363 commit ffbb4b8

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

pkg/providers/v1/aws_validations_test.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ func TestValidateServiceAnnotations(t *testing.T) {
417417
expectedError: "target group attributes annotation is only supported for NLB",
418418
},
419419

420-
// IPFamily annotation set to dualstack (should succeed)
420+
// IPFamily annotation set to dualstack on NLB (should succeed)
421421
{
422422
name: "NLB with dualstack annotation - success",
423423
annotations: map[string]string{
@@ -427,6 +427,15 @@ func TestValidateServiceAnnotations(t *testing.T) {
427427
expectedError: "",
428428
},
429429

430+
// IPFamily annotation set to dualstack on CLB (should fail)
431+
{
432+
name: "CLB with dualstack annotation - fail",
433+
annotations: map[string]string{
434+
ServiceAnnotationLoadBalancerIPAddressType: "dualstack",
435+
},
436+
expectedError: "ip address type annotation is only supported for NLB",
437+
},
438+
430439
// No annotations (should succeed)
431440
{
432441
name: "no annotations - success",

0 commit comments

Comments
 (0)