Merge pull request #360 from omertuc/brokentest

k8s-ci-robot · web-flow · commit 0fc8f792897b · 2024-06-13T06:54:27.000-07:00
Fix broken `TestCACacheVerify` test
diff --git a/cmd/gcp-controller-manager/ca_cache_test.go b/cmd/gcp-controller-manager/ca_cache_test.go
@@ -41,6 +41,8 @@ func TestCACacheVerify(t *testing.T) {
 			}
 		})
 		for desc, invalidCert := range ca.invalidCerts {
+			desc := desc
+			invalidCert := invalidCert
 			t.Run(desc, func(t *testing.T) {
 				t.Parallel()
 				if err := c.verify(invalidCert); err == nil {

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,8 @@ func TestCACacheVerify(t *testing.T) {`
`41`	`41`	`}`
`42`	`42`	`})`
`43`	`43`	`for desc, invalidCert := range ca.invalidCerts {`
	`44`	`+ desc := desc`
	`45`	`+ invalidCert := invalidCert`
`44`	`46`	`t.Run(desc, func(t *testing.T) {`
`45`	`47`	`t.Parallel()`
`46`	`48`	`if err := c.verify(invalidCert); err == nil {`