Only perform chart lint, remove install step (#1227) (#1233)

* Only perform chart lint, remove install step (#1227)

For the chart install to work, the Kubernetes cluster needs to be able
to talk to an OpenStack cloud which cannot be done in the CI. Therefore,
only perform the lint test and disable install.

(cherry picked from commit 534bf32)

* [cinder-csi-plugin] Update snapshotter to v2.1.1 in charts

(cherry picked from commit c507740)

* Lint chart against release-1.19 branch and not master

Co-authored-by: Anusha Ramineni <[email protected]>

Author: brtkwr

.github/workflows/config/ct.yaml

@@ -0,0 +1 @@
+target-branch: release-1.19

.github/workflows/pr.yaml

@@ -1,30 +1,9 @@
-name: Lint and Test Charts
+name: Lint Charts
 
 on: pull_request
 
 jobs:
-  changes:
-    outputs:
-      charts: ${{ steps.filter.outputs.charts }}
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v2
-
-      - id: filter
-        uses: dorny/[email protected]
-        with:
-          filters: |
-            charts:
-              - 'charts/**/Chart.yaml'
-              - 'charts/**/*'
-          token: ${{ secrets.GITHUB_TOKEN }}
-
-  helm-lint-test:
-    if: ${{ needs.changes.outputs.charts == 'true' }}
-    name: Helm chart
-    needs:
-      - changes
+  lint:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
@@ -38,13 +17,4 @@ jobs:
         uses: helm/[email protected]
         with:
           command: lint
-
-      # Only build a kind cluster if there are chart changes to test.
-      - if: steps.lint.outputs.changed == 'true'
-        name: Create kind cluster
-        uses: helm/[email protected]
-
-      - name: Run chart-testing (install)
-        uses: helm/[email protected]
-        with:
-          command: install
+          config: .github/workflows/config/ct.yaml

charts/cinder-csi-plugin/templates/controllerplugin-rbac.yaml

@@ -89,37 +89,25 @@ apiVersion: rbac.authorization.k8s.io/v1
 metadata:
   name: csi-snapshotter-role
 rules:
-  - apiGroups: [""]
-    resources: ["persistentvolumes"]
-    verbs: ["get", "list", "watch"]
-  - apiGroups: [""]
-    resources: ["persistentvolumeclaims"]
-    verbs: ["get", "list", "watch"]
-  - apiGroups: ["storage.k8s.io"]
-    resources: ["storageclasses"]
-    verbs: ["get", "list", "watch"]
   - apiGroups: [""]
     resources: ["events"]
     verbs: ["list", "watch", "create", "update", "patch"]
-  - apiGroups: [""]
-    resources: ["secrets"]
-    verbs: ["get", "list"]
+  # Secret permission is optional.
+  # Enable it if your driver needs secret.
+  # For example, `csi.storage.k8s.io/snapshotter-secret-name` is set in VolumeSnapshotClass.
+  # See https://kubernetes-csi.github.io/docs/secrets-and-credentials.html for more details.
+  #  - apiGroups: [""]
+  #    resources: ["secrets"]
+  #    verbs: ["get", "list"]
   - apiGroups: ["snapshot.storage.k8s.io"]
     resources: ["volumesnapshotclasses"]
     verbs: ["get", "list", "watch"]
   - apiGroups: ["snapshot.storage.k8s.io"]
     resources: ["volumesnapshotcontents"]
     verbs: ["create", "get", "list", "watch", "update", "delete"]
   - apiGroups: ["snapshot.storage.k8s.io"]
-    resources: ["volumesnapshots"]
-    verbs: ["get", "list", "watch", "update"]
-  - apiGroups: ["snapshot.storage.k8s.io"]
-    resources: ["volumesnapshots/status"]
+    resources: ["volumesnapshotcontents/status"]
     verbs: ["update"]
-  - apiGroups: ["apiextensions.k8s.io"]
-    resources: ["customresourcedefinitions"]
-    verbs: ["create", "list", "watch", "delete"]
-
 ---
 kind: ClusterRoleBinding
 apiVersion: rbac.authorization.k8s.io/v1