Fix wrong pointer in range loop (#1198) (#1209)

range copies the value as a local variable in the loop.
Getting the pointer from it makes all the elements in the map point to
the last value that the range variable copied.

Change to get value with index from array directly.

Co-authored-by: Phillip <[email protected]>

Author: lingxiankong

pkg/cloudprovider/providers/openstack/openstack_loadbalancer.go

@@ -1100,9 +1100,9 @@ func (lbaas *LbaasV2) ensureOctaviaPool(lbID string, listener *listeners.Listene
 func (lbaas *LbaasV2) ensureOctaviaListener(lbID string, oldListeners []listeners.Listener, service *corev1.Service, port corev1.ServicePort, svcConf *serviceConfig) (*listeners.Listener, error) {
 	// Get all listeners by "port&protocol".
 	lbListeners := make(map[listenerKey]*listeners.Listener)
-	for _, l := range oldListeners {
+	for i, l := range oldListeners {
 		key := listenerKey{Protocol: listeners.Protocol(l.Protocol), Port: l.ProtocolPort}
-		lbListeners[key] = &l
+		lbListeners[key] = &oldListeners[i]
 	}
 
 	proto := toListenersProtocol(port.Protocol)