Fix X509 verification test against Go 1.24

Author: dougm

pkg/common/vclib/connection_test.go

@@ -29,7 +29,7 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/pkg/errors"
+	"github.com/vmware/govmomi/vim25/soap"
 
 	"k8s.io/cloud-provider-vsphere/pkg/common/vclib"
 	"k8s.io/cloud-provider-vsphere/pkg/common/vclib/fixtures"
@@ -134,7 +134,9 @@ func TestWithVerificationWithoutCaCertOrThumbprint(t *testing.T) {
 
 	_, err := connection.NewClient(context.Background())
 
-	verifyWrappedX509UnkownAuthorityErr(t, err)
+	if !soap.IsCertificateUntrusted(err) {
+		t.Fatalf("Expected soap.IsCertificateUntrusted, got: '%s' (%#v)", err.Error(), err)
+	}
 }
 
 func TestWithValidThumbprint(t *testing.T) {
@@ -184,21 +186,6 @@ func TestInvalidCaCert(t *testing.T) {
 	}
 }
 
-func verifyWrappedX509UnkownAuthorityErr(t *testing.T, err error) {
-	urlErr, ok := err.(*url.Error)
-	if !ok {
-		t.Fatalf("Expected to receive an url.Error, got '%s' (%#v)", err.Error(), err)
-	}
-	x509Err := &x509.UnknownAuthorityError{}
-	ok = errors.As(urlErr.Err, x509Err)
-	if !ok {
-		t.Fatalf("Expected to receive a wrapped x509.UnknownAuthorityError, got: '%s' (%#v)", urlErr.Error(), urlErr)
-	}
-	if msg := x509Err.Error(); msg != "x509: certificate signed by unknown authority" {
-		t.Fatalf("Expected 'signed by unknown authority' error, got: '%s'", msg)
-	}
-}
-
 func getRequestVerifier(t *testing.T) (http.HandlerFunc, func()) {
 	gotRequest := false