Return nil when VirtualMachineService is not found (#1551)

Currently when virtualmachineservice is not found, an err is returned
and cloud provider reports err and won't able to delete LB Service anymore.
Actually CPI should return nil in this case.

Author: zhanggbj

pkg/cloudprovider/vsphereparavirtual/loadbalancer.go

@@ -68,9 +68,11 @@ func (l *loadBalancer) GetLoadBalancer(ctx context.Context, clusterName string,
 		return nil, false, err
 	}
 
+	// When err is nil and vmService is nil, it indicates VirtualMachineService not found, but it's not an error.
+	// Return nil so that cloud provider could move on and delete the LB service.
 	if vmService == nil {
-		klog.Errorf("failed to get load balancer for %s: VirtualMachineService not found", namespacedName(service))
-		return nil, false, errors.Errorf("VirtualMachineService not found")
+		klog.V(1).Infof("VirtualMachineService not found %s", namespacedName(service))
+		return nil, false, nil
 	}
 
 	return toStatus(vmService), true, nil

pkg/cloudprovider/vsphereparavirtual/loadbalancer_test.go

@@ -104,7 +104,7 @@ func TestGetLoadBalancer_VMServiceNotFound(t *testing.T) {
 
 	_, exists, err := lb.GetLoadBalancer(context.Background(), testClustername, testK8sService)
 	assert.Equal(t, exists, false)
-	assert.Error(t, err)
+	assert.NoError(t, err)
 }
 
 func TestGetLoadBalancer_VMServiceCreated(t *testing.T) {