We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
2 parents 49c52ea + 5c71e1f commit 60f3c93Copy full SHA for 60f3c93
sig-scheduling/CONTRIBUTING.md
@@ -104,7 +104,7 @@ Testing:
104
should be considered for critical and/or CPU intensive operations.
105
- General guidelines:
106
- Follow a [DAMP principle](https://stackoverflow.com/a/11837973).
107
- - Use `cmp.Diff` instead of `reflect.Equal`, to provide useful comparisons.
+ - Use `cmp.Diff` instead of `reflect.DeepEqual`, to provide useful comparisons.
108
- Compare errors using `errors.Is` (`cmpopts.EquateErrors` when using
109
`cmp.Diff`) instead of comparing the error strings.
110
- Leverage existing utility functions from `pkg/scheduler/testing`.
0 commit comments