Skip to content

Commit 60f3c93

Browse files
authored
Merge pull request #7706 from sivchari/fix-incorrect-function-name
revise from reflect.Equal to reflect.DeepEqual
2 parents 49c52ea + 5c71e1f commit 60f3c93

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sig-scheduling/CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ Testing:
104104
should be considered for critical and/or CPU intensive operations.
105105
- General guidelines:
106106
- Follow a [DAMP principle](https://stackoverflow.com/a/11837973).
107-
- Use `cmp.Diff` instead of `reflect.Equal`, to provide useful comparisons.
107+
- Use `cmp.Diff` instead of `reflect.DeepEqual`, to provide useful comparisons.
108108
- Compare errors using `errors.Is` (`cmpopts.EquateErrors` when using
109109
`cmp.Diff`) instead of comparing the error strings.
110110
- Leverage existing utility functions from `pkg/scheduler/testing`.

0 commit comments

Comments
 (0)