Skip to content

Commit 6a97ae2

Browse files
authored
Merge pull request #6884 from valaparthvi/patch-1
Fix typos in the conformance-tests doc
2 parents 43e5efa + d0cb25a commit 6a97ae2

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

contributors/devel/sig-architecture/conformance-tests.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,15 +107,15 @@ Generally speaking, the goals are to:
107107
- Make sure tests that are already passing remain passing. If new OS-specific
108108
functionality is added, it should be in a new test.
109109
- Ensure that new tests covering Linux-specific functionality are tagged with `[LinuxOnly]`
110-
(see: [Kinds of Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/e2e-tests.md#kinds-of-tests),
110+
(see: [Kinds of Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/e2e-tests.md#kinds-of-tests)).
111111
- Give future reviewers a reference to an active issue or documentation clarifying why a test
112112
cannot run on Windows.
113113

114114
The tests that are running today:
115115

116116
- Rely only on container images that already have a multi-architecture manifest
117117
including Windows versions, or have been ported by SIG-Windows
118-
(see [kubernetes-sigs/windows-testing/images](https://github.com/kubernetes-sigs/windows-testing/tree/master/images)
118+
(see [kubernetes-sigs/windows-testing/images](https://github.com/kubernetes-sigs/windows-testing/tree/master/images)).
119119
- Do not depend on any functionality that is different or not available on Windows. The full list
120120
is available in the Windows Kubernetes docs under [api](https://kubernetes.io/docs/setup/windows/intro-windows-in-kubernetes/#api).
121121
A brief summary is included here as a starting point. If the docs are insufficient
@@ -139,7 +139,7 @@ implicitly by Docker or ContainerD, not by the kubelet. Do not check properties
139139
- Networking
140140
- Pods set `HostNetwork=true`. For Windows, this can only be enabled for Windows Privileged Containers. In other cases, the Pod will not start.
141141
- Network and DNS settings must be passed through CNI. Windows does not use `/etc/resolv.conf`, so tests should not rely on reading that file to check DNS settings.
142-
- If you to check network settings such as dns search lists, please use [agnhost](https://github.com/kubernetes/kubernetes/tree/master/test/images/agnhost) to output needed data from the container.
142+
- If you want to check network settings such as dns search lists, please use [agnhost](https://github.com/kubernetes/kubernetes/tree/master/test/images/agnhost) to output needed data from the container.
143143
- Windows treats all DNS lookups with a `.` to be FQDN, not PQDN. For example `kubernetes` will resolve as a PQDN,
144144
but `kubernetes.default` will be resolved as a FQDN and fail.
145145
- ICMP only works between pods on the same network, and are not routable to external networks. TCP/UDP are routable.
@@ -276,8 +276,7 @@ this approval process:
276276
- changes to the conformance criteria or process
277277
- changes to the conformance infrastructure code
278278

279-
There are six columns in this board. New PRs should enter in the To Triage
280-
column, and [Conformance test reviewers] will pick it up from there and move it
279+
New PRs should enter in the To Triage column, and [Conformance test reviewers] will pick it up from there and move it
281280
through the process. New end-to-end tests that are intended to be promoted to
282281
conformance tests in the future may be added to this board, but they will not
283282
move all the way to the Needs Approval column, as that is intended only for the

0 commit comments

Comments
 (0)