Skip to content

Commit 7648177

Browse files
authored
Merge pull request #7052 from ehashman/inst-2022
Add sig-instrumentation 2022 meeting note archive
2 parents ea23639 + b6a7028 commit 7648177

File tree

2 files changed

+304
-0
lines changed

2 files changed

+304
-0
lines changed
545 KB
Loading
Lines changed: 304 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,304 @@
1+
## Triage (2022-12-29)
2+
3+
Cancelled - winter holidays
4+
5+
6+
## Agenda (2022-12-22)
7+
8+
Cancelled - winter holidays
9+
10+
11+
## [NEXT] Triage (2022-12-15)
12+
13+
14+
## Agenda (2022-12-08):
15+
16+
* Deep Dive Video is out on Youtube -
17+
* [] - maintaining subprojects + status
18+
* KSM: new contributors, improving; most active subproject w/3 active
19+
approvers and 3 new active reviewers, lots of first-time contributors!
20+
* Metrics-server: We have 2 active reviewers and 1 active approver, only one
21+
approver. Doing the bare minimum
22+
* Custom-metrics-apiserver: need to keep maintaining this. Damien only
23+
approver, doesn’t have time, Olivier is working on it
24+
* prometheus-metrics-adapter: should we consider archiving? There’s now a
25+
good replacement, KEDA, with bigger scope
26+
([https://keda.sh/docs/1.4/scalers/prometheus/](https://keda.sh/docs/1.4/scalers/prometheus/)).
27+
Hasn’t been well-maintained, project needs a rewrite because the codebase
28+
is hard to understand, UX is suboptimal, debugging is very complex and
29+
tedious. Maybe write a migration guide rather than cleaning up KSM.
30+
* Can we consider adding people directly to subproject ownership in the new year?
31+
* Don’t want to give a newbie maintainer status without mentorship
32+
* Seems reasonable to add people as reviewers right away if requested;
33+
approver is a higher bar
34+
* Reviewer status gives you some feelings of ownership and
35+
responsibility but doesn’t give any privileges above and beyond org
36+
member. For people who are not yet org members, we can work with them.
37+
* [yangjunmyfm192085] Ask the release plan of metrics-server
38+
* I think We need to make a release plan for metrics-server v0.6.2 and v0.7.0
39+
* Marek didn’t have time for a while to cut releases. Damien should now have
40+
permissions to cut the release, but going forward wants to find someone
41+
else to do it. Was difficult to release because it had been 6+ months
42+
between releases so bumping dependencies was tedious. We should be
43+
releasing every month or 2, at minimum every go version.
44+
* Han volunteers, Catherine will think about it. Olivier will look into
45+
contributing as well.
46+
* Not a lot of new code changes to make, project is pretty stable now, just
47+
need to keep maintaining (bumping dependencies, bug fixes, CVE management,
48+
releases, etc.)
49+
* [ehashman] Repo created for [https://github.com/kubernetes-sigs/usage-metrics-collector](https://github.com/kubernetes-sigs/usage-metrics-collector)
50+
* Got repo created in the last few weeks.
51+
* Waiting for approval to push code externally, hopefully by end of year, at
52+
latest January.
53+
* Once public, we can do a walk-the-code update/demo on a meeting?
54+
* [Paige] Does SIG instrumentation do tracing for system components?
55+
* Yes! This is being led by David Ashpole (API server)
56+
* API server tracing should go beta in the next release
57+
* Kubelet tracing (Sally O’Malley) - currently in alpha, lots of changes
58+
required before beta
59+
60+
## Agenda (2022-11-10)
61+
62+
* [Pranshu] KSM’s own mixin’s project?
63+
* [Pranshu] Enabling discussions on the repository (can start with KSM).
64+
* Already enabled
65+
* [Pranshu] Shadow program follow-ups ()?
66+
* More [members](https://github.com/kubernetes/community/blob/master/community-membership.md#requirements)?
67+
* Forms rollout, assessing possible major tasks.
68+
* [Benjamin Saint-Cyr] Demo of kernel tracing for kubelets.
69+
70+
![Screenshot of Trace Compass app showing Kubelet CPU usage and control flow](2022-kubelet-tracing.png)
71+
72+
* https://github.com/BenjaminSaintCyr/k8s-instrumentation-demo
73+
74+
75+
## Notes from Kubecon SIG F2F:
76+
77+
* Better guidelines/documentations for metrics and logs and traces
78+
1. Answering basic questions like which logger should we use in k8s custom controllers
79+
* Move documentation to website
80+
* Does kubebuilder use component-base?
81+
2. Should look into migrating metrics stuff to component-base
82+
* Should we promote metrics/resource to stable?
83+
* Metrics server scalability
84+
3. We need to graduate metrics/resource metrics to stable status.
85+
* Kubelet metrics should possibly sharded to different endpoints
86+
* Better first-time issues
87+
88+
89+
## Agenda (2022-10-13)
90+
91+
* [pwittrock] [Proposal for new sig project for usage metrics](https://docs.google.com/document/d/12JEje-SpM78N5OhZzWg-_Ba91n6VWRm5c4l_c2U-ljw/edit#)
92+
* AI: ehashman to open issue with kubernetes/org for repo creation.
93+
94+
95+
## Agenda (2022-09-29)
96+
97+
* Shadow Program:
98+
99+
100+
## Agenda (2022-09-15)
101+
102+
* [dashpole] Plans for KEPs in 1.26?
103+
* [https://github.com/kubernetes/enhancements/issues?q=is%3Aopen+is%3Aissue+label%3Asig%2Finstrumentation](https://github.com/kubernetes/enhancements/issues?q=is%3Aopen+is%3Aissue+label%3Asig%2Finstrumentation)
104+
* AI: Document [logtools](https://github.com/kubernetes-sigs/logtools) as a sub-project
105+
* KSM v3.0 planning: [https://github.com/orgs/kubernetes/projects/90/views/1](https://github.com/orgs/kubernetes/projects/90/views/1)
106+
107+
108+
## Agenda (2022-09-01)
109+
110+
* [logicalhan] - [https://github.com/kubernetes/enhancements/pull/3469/](https://github.com/kubernetes/enhancements/pull/3469/)
111+
* [logicalhan] - status of metrics framework KEP
112+
* [dgrisonnet] taking ownership of events/v1 migration [https://github.com/kubernetes/enhancements/issues/383](https://github.com/kubernetes/enhancements/issues/383)
113+
* New KEP to plan a safe migration path for all the kube components:
114+
* Need new per EventSeries backoff mechanism
115+
* Rate-limiting for unique Events
116+
117+
118+
## Agenda (2022-08-18)
119+
120+
* No agenda items to discuss
121+
122+
123+
## Agenda (2022-08-04)
124+
125+
* [raptorsun (just taking notes)] Metrics API/Server
126+
* Metrics API stability
127+
* Resource usage / performance of Metrics server implementation
128+
* Notes:
129+
* We can always do a v2 if needed
130+
* We can always replace the metrics server with a better implementation
131+
* [logicalhan] extending stability update
132+
* [dashpole] Kubelet Tracing made it into 1.25!
133+
* Follow-ups for etcd:
134+
* Ask for increasing otel library version to 1.0+ in 3.5?
135+
* Ask to change the default sampling rate to 0 from 100%. (bug fix)
136+
137+
138+
## Agenda (2022-07-21)
139+
140+
* [raptorsun] kubctl top + node column & memory unit [issue](https://github.com/kubernetes/kubernetes/issues/110722)
141+
* To discuss in next meeting:
142+
* Metrics API stability
143+
* Resource usage / performance of Metrics server implementation
144+
* [after a meeting note from serathius@ (owner of Metrics Server)]. Please reach out to me on Slack if you have any questions.
145+
146+
147+
## Agenda (2022-07-07)
148+
149+
* [serathius] Question about admin experience on reliability of K8s logs.
150+
* Is anyone running high log generating applications?
151+
* What’s your experience with log reliability? Have you noticed logs being lost?
152+
* Do you measure the percentage of logs delivered?
153+
* If you or someone you know had this problem, would love to talk. Feel free to reach out to @serathius on K8s Slack
154+
155+
156+
## Agenda (2022-06-23)
157+
158+
* [dgrisonnet] Standardizing metrics initialization and registration in k/k:
159+
* [https://github.com/kubernetes/kubernetes/pull/110027/files#r872226087](https://github.com/kubernetes/kubernetes/pull/110027/files#r872226087)
160+
* [serathius] Question about admin experience on reliability of K8s logs.
161+
* Serathius - will not be able to attend. Feel free to skip.
162+
* [dashpole,dgrisonnet] OpenTelemetry and Prometheus Exponential (Sparse) Histograms continuation
163+
* Concern about migrating to sparse histogram: Cardinality when producing fixed buckets?
164+
* AI: Write a strawman document for how we would do a migration. Share with the prometheus folks to see if any concerns/problems are addressable.
165+
* [catherineF-dev] High cardinitiy metric apiserver_request_duration_seconds_bucket [https://github.com/kubernetes/kubernetes/issues/110742](https://github.com/kubernetes/kubernetes/issues/110742)
166+
* Trace + one simplified metric (only capture high latency cases and drop some labels)
167+
* AI: Look into adding exemplars to the metric and traceid to the audit logs
168+
* [serathius] ^ Looks like more structured logging thing then audit log
169+
170+
171+
## Agenda (2022-06-09)
172+
173+
* [raptorsun, dgrisonnet] Improve kubectl top UX with PodMetrics
174+
* [https://github.com/kubernetes/kubernetes/issues/102051](https://github.com/kubernetes/kubernetes/issues/102051)
175+
* [https://github.com/kubernetes/kubectl/issues/830](https://github.com/kubernetes/kubectl/issues/830)
176+
* [dashpole] OpenTelemetry and Prometheus Exponential (Sparse) Histograms
177+
*
178+
* TL;DR they differ on bucket start being inclusive vs exclusive.
179+
* Do we consider it backwards-compatible to switch from fixed-bucket histograms to exponential histograms (since it changes bucket boundaries)? Would we switch histograms to exponential histograms if bucket boundaries are the only thing that changes?
180+
181+
182+
## Agenda (2022-05-12)
183+
184+
* KEP planning - Enhancement freeze June 16th
185+
186+
187+
## Agenda (2022-04-28)
188+
189+
* Canceled due to technical difficulties.
190+
191+
192+
## Agenda (2022-04-14)
193+
194+
* Announcements
195+
* Release delayed until May 3rd: [https://github.com/kubernetes/sig-release/pull/1884](https://github.com/kubernetes/sig-release/pull/1884)
196+
* Discussion from Chairs/Leads:
197+
* Ensuring test flakes get fixed
198+
* [https://github.com/kubernetes/kubernetes/issues?q=is%3Aopen+is%3Aissue+label%3Asig%2Finstrumentation+label%3Akind%2Fflake](https://github.com/kubernetes/kubernetes/issues?q=is%3Aopen+is%3Aissue+label%3Asig%2Finstrumentation+label%3Akind%2Fflake)
199+
* Improving Kubernetes reliability
200+
* Improving the enhancements process
201+
* There is a huge amount of toil in writing KEPs/adding metadata,
202+
particularly when much of the information is available in the git
203+
history already
204+
* Kepctl is useful but most people don’t know it exists and it often
205+
breaks, needs frequent patches in order to work. If documentation was
206+
improved, might be helpful
207+
* KEP process is very painful, giant barrier for new contributors; can
208+
we think bigger and reimagine the process rather than just adding
209+
tooling (technical solutions to a process problem)?
210+
* SIG is okay with changes to kep.yaml files so long as tools
211+
autogenerate all changes, no additional manual work for contributors
212+
213+
214+
## Triage (2022-04-07)
215+
216+
217+
## Agenda (2022-03-31)
218+
219+
Canceled - no agenda
220+
221+
222+
## Agenda (2022-03-17)
223+
224+
* Reminder: code freeze
225+
* Milestone review: bumped API tracing beta to 1.25
226+
* [serathius,pohly] Needs reviewers for klog
227+
* [https://github.com/kubernetes/klog/issues/222](https://github.com/kubernetes/klog/issues/222)
228+
* **Action:** serathius will run the maintainers script to update OWNERS file
229+
230+
231+
## Agenda (2022-03-03)
232+
233+
* [Leads] Annual report
234+
* [https://github.com/kubernetes/community/pull/6463](https://github.com/kubernetes/community/pull/6463)
235+
* Should be merged by Mar. 1
236+
* [dgrisonnet,sanchezl] Adding a new bounded dimension to a stable metric.
237+
Extending apiserver_admission_webhook_admission_duration with a bounded
238+
resource label for finer grained SLO.
239+
* [https://github.com/kubernetes/kubernetes/pull/69895](https://github.com/kubernetes/kubernetes/pull/69895)
240+
* [https://github.com/kubernetes/kubernetes/pull/108468](https://github.com/kubernetes/kubernetes/pull/108468)
241+
242+
243+
## Triage (2022-02-24)
244+
245+
246+
## Agenda (2022-02-17)
247+
248+
* [Leads] Annual report
249+
* [https://github.com/kubernetes/community/pull/6463](https://github.com/kubernetes/community/pull/6463)
250+
* [ehashman] Charter update FYI
251+
* Adds tracing, removes heapster
252+
* [https://github.com/kubernetes/community/pull/6464](https://github.com/kubernetes/community/pull/6464)
253+
*
254+
255+
256+
## Triage (2022-02-10)
257+
258+
* [hase1128] Continue to discuss the idea for KEP2312 \
259+
[https://github.com/kubernetes/enhancements/pull/2312](https://github.com/kubernetes/enhancements/pull/2312) \
260+
Doc URL(I uploaded on slack): [https://kubernetes.slack.com/archives/C20HH14P7/p1643912029063699](https://kubernetes.slack.com/archives/C20HH14P7/p1643912029063699)
261+
262+
263+
## Agenda (2022-02-03)
264+
265+
* Announcements
266+
* Final KEP review: deadline is today
267+
* [dgrisonnet] Improve tooling to make sure that all PRs modifying a metrics.go file, are approved by sig-instrumentation.
268+
* [hase1128] I would like to get feedback about my current idea for KEP2312 \
269+
[https://github.com/kubernetes/enhancements/pull/2312](https://github.com/kubernetes/enhancements/pull/2312) \
270+
Doc URL(I uploaded on slack): [https://kubernetes.slack.com/archives/C20HH14P7/p1643912029063699](https://kubernetes.slack.com/archives/C20HH14P7/p1643912029063699)
271+
272+
273+
## Triage (2022-01-27)
274+
275+
276+
## Agenda (2022-01-20)
277+
278+
* Announcements
279+
* Damien is our new TL!
280+
* Reminder: upcoming release dates
281+
* [fromani] (can be postponed, 1.24 or beyond) klog: towards per-flow verbosity
282+
* Looking for previous history/attempts (if any) and design yay/nay
283+
* Probably deserves a full KEP, will write depending on the above bullet point
284+
* POC/usecase description [here](https://github.com/kubernetes-sigs/scheduler-plugins/pull/289) (caveat: security implications not addressed)
285+
* [dashpole] Stable metric deprecation period discussion: Should stable metrics be permanent?
286+
* [https://github.com/kubernetes/website/pull/31389#pullrequestreview-856542765](https://github.com/kubernetes/website/pull/31389#pullrequestreview-856542765)
287+
288+
289+
## Triage (2022-01-13)
290+
291+
292+
## Agenda (2022-01-06)
293+
294+
* Announcements
295+
* 1.24 dates not yet finalized
296+
* Week 1: January 10
297+
* Week ???: Release planned for April 19
298+
* [Leads] New TL update
299+
* Congrats Damien!
300+
* Lazy consensus: need to submit PR/mailing list post
301+
* Also need to clean up OWNERS files with leads once done
302+
* [ehashman] 1.24 KEP planning, continued
303+
* [logicalhan]
304+
* [dgrisonnet] Possible new KEPs

0 commit comments

Comments
 (0)