Skip to content

Commit 7795e2b

Browse files
authored
Merge pull request #5779 from MadhavJivrajani/master
Add documentaion for tide/squash-on-merge
2 parents ca0ca53 + c4906d2 commit 7795e2b

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

contributors/guide/contributor-cheatsheet/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ git rebase -i HEAD~3
374374
git push --force
375375
```
376376

377-
377+
**Note**: you can also ask your reviewer to add the `tide/merge-method-squash` label to your PR (this can be done by a reviewer by issuing the command: `/label tide/merge-method-squash`), this will let the bot take care of squashing _all_ commits that are part of this PR and will not result in removal of the `LGTM` label (if already applied) or re-run of the CI tests.
378378

379379
[contributor guide]: /contributors/guide/README.md
380380
[developer guide]: /contributors/devel/README.md

contributors/guide/pull-requests.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,8 @@ For more information, see [squash commits](./github-workflow.md#squash-commits).
291291
Don't squash when there are independent changes layered to achieve a single goal.
292292
For instance, writing a code munger could be one commit, applying it could be another, and adding a precommit check could be a third.
293293
One could argue they should be separate pull requests, but there's really no way to test/review the munger without seeing it applied, and there needs to be a precommit check to ensure the munged output doesn't immediately get out of date.
294+
295+
**Note**: you can also ask your reviewer to add the `tide/merge-method-squash` label to your PR (this can be done by a reviewer by issuing the command: `/label tide/merge-method-squash`), this will let the bot take care of squashing _all_ commits that are part of this PR and will not result in removal of the `LGTM` label (if already applied) or re-run of the CI tests.
294296

295297
## Commit Message Guidelines
296298

0 commit comments

Comments
 (0)