Skip to content

Commit 9a4dbd3

Browse files
committed
Remove recommendation for condition heartbeat
Heartbeats previously caused significant standing load, they are not recommended for API types.
1 parent 8f0e7a9 commit 9a4dbd3

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

contributors/devel/sig-architecture/api-conventions.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -405,8 +405,6 @@ following fields, but must contain at least `type` and `status` fields:
405405
// +optional
406406
Message *string `json:"message,omitempty" description:"human-readable message indicating details about last transition"`
407407

408-
// +optional
409-
LastHeartbeatTime *unversioned.Time `json:"lastHeartbeatTime,omitempty" description:"last time we got an update on a given condition"`
410408
// +optional
411409
LastTransitionTime *unversioned.Time `json:"lastTransitionTime,omitempty" description:"last time the condition transit from one status to another"`
412410
```
@@ -417,9 +415,6 @@ Do not use fields that you don't need - simpler is better.
417415

418416
Use of the `Reason` field is encouraged.
419417

420-
Use the `LastHeartbeatTime` with great caution - frequent changes to this field
421-
can cause a large fan-out effect for some resources.
422-
423418
Condition types should be named in PascalCase. Short condition names are
424419
preferred (e.g. "Ready" over "MyResourceReady").
425420

0 commit comments

Comments
 (0)