Skip to content

Commit b55a1da

Browse files
committed
Update based upon review feedback
1 parent 60220df commit b55a1da

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

sig-architecture/production-readiness.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Production readiness reviews are done by a separate team, apart from the SIG
99
leads (although SIG lead approval is needed as well, of course). It is useful to
1010
have the viewpoint of a team that is not as familiar with the intimate details
1111
of the SIG, but *is* familiar with Kubernetes and with operating Kubernetes in
12-
production. Experience through our dry runs in 1.19 and 1.20 have shown that
12+
production. Experience through our dry runs in 1.17-1.20 have shown that
1313
this slightly "outsider" view helps identify otherwise missed items.
1414

1515
More background may be found in the [PRR KEP].
@@ -18,8 +18,7 @@ More background may be found in the [PRR KEP].
1818

1919
As of 1.21, PRRs are now blocking. PRR _approval_ is required for the enhancement
2020
to be part of the release. This means that any KEPs targeting the release for any
21-
stage, and in - or moving to - `implementable` state, will require production
22-
readiness approval by the *Enhancements Freeze Date*.
21+
stage will require production readiness approval by the *Enhancements Freeze Date*.
2322

2423
Note that some of the questions in the [KEP template] should be answered in both
2524
the KEP's README.md and the `kep.yaml`, in order to support automated checks on
@@ -35,7 +34,8 @@ the PRR answers, the authors may request PRR approval:
3534
* Assign a PRR approver from the `prod-readiness-approvers` list in the
3635
[OWNERS_ALIASES] file. This may be done earlier as well, to get early feedback
3736
or just to let the approver know. Reach out on the `#prod-readiness` Slack
38-
channel or just pick someone from the list.
37+
channel or just pick someone from the list. The team may rebalance the
38+
assignees if necessary.
3939
* Update the `kep.yaml`, setting the `stage`, `latest-milestone`, and the
4040
`milestone` struct (which captures per-stage release versions).
4141
* Create a `prod-readiness/<sig>/<KEP number>.yaml` file, with the PRR
@@ -89,6 +89,6 @@ that need review. For example:
8989
[PRR KEP]: https://git.k8s.io/enhancements/keps/sig-architecture/1194-prod-readiness
9090
[KEP template]: https://git.k8s.io/enhancements/keps/NNNN-kep-template
9191
[OWNERS_ALIASES]: https://git.k8s.io/enhancements/OWNERS_ALIASES
92-
[example PRR approval request PR]: https://github.com/kubernetes/enhancements/pull/2274/files
92+
[example PRR approval request PR]: https://github.com/kubernetes/enhancements/pull/2179/files
9393
[example metrics PR]: https://github.com/kubernetes/kubernetes/pull/97814
9494
[kepctl query]: https://git.k8s.io/enhancements/cmd/kepctl

0 commit comments

Comments
 (0)