You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixed inconsistent first character capitalization. (#6778)
* Fixed inconsistent first character capitalization.
In some bullet points there were words where first character wasn't in uppercase and in some they were. Fixed the inconsistency.
* Update contributing.md
Copy file name to clipboardExpand all lines: contributors/guide/contributing.md
+7-7Lines changed: 7 additions & 7 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -60,9 +60,9 @@ Refer to its [command reference documentation](https://go.k8s.io/bot-commands).
60
60
61
61
Common new contributor PR issues are:
62
62
63
-
*not having correctly signed the CLA ahead of your first PR. See the [CLA page](/CLA.md) for troubleshooting help, in some cases you might need to file a ticket with the CNCF to resolve a CLA problem.
64
-
*finding the right SIG or reviewer(s) for the PR (see [Code Review](#code-review) section) and following any SIG or repository specific contributing guidelines (see [Learn about SIGs](first-contribution.md#learn-about-sigs) section)
65
-
*dealing with test cases which fail on your PR, unrelated to the changes you introduce (see [Test Flakes](/contributors/devel/sig-testing/flaky-tests.md))
63
+
*Not having correctly signed the CLA ahead of your first PR. See the [CLA page](/CLA.md) for troubleshooting help, in some cases you might need to file a ticket with the CNCF to resolve a CLA problem.
64
+
*Finding the right SIG or reviewer(s) for the PR (see [Code Review](#code-review) section) and following any SIG or repository specific contributing guidelines (see [Learn about SIGs](first-contribution.md#learn-about-sigs) section)
65
+
*Dealing with test cases which fail on your PR, unrelated to the changes you introduce (see [Test Flakes](/contributors/devel/sig-testing/flaky-tests.md))
66
66
* Not following [scalability good practices](scalability-good-practices.md)
67
67
* Include mentions (like @person) and [keywords](https://help.github.com/en/articles/closing-issues-using-keywords) which could close the issue (like fixes #xxxx) in commit messages.
68
68
@@ -73,10 +73,10 @@ There are two aspects of code review: giving and receiving.
73
73
74
74
To make it easier for your PR to receive reviews, consider the reviewers will need you to:
75
75
76
-
*follow the project [coding conventions](coding-conventions.md)
*break large changes into a logical series of smaller patches which individually make easily understandable changes, and in aggregate solve a broader issue
79
-
*label PRs with appropriate SIGs and reviewers: to do this read the messages the bot sends you to guide you through the PR process
76
+
*Follow the project [coding conventions](coding-conventions.md)
*Break large changes into a logical series of smaller patches which individually make easily understandable changes, and in aggregate solve a broader issue
79
+
*Label PRs with appropriate SIGs and reviewers: to do this read the messages the bot sends you to guide you through the PR process
80
80
81
81
Reviewers, the people giving the review, are highly encouraged to revisit the [Code of Conduct](/code-of-conduct.md) as well as [community expectations](./expectations.md#expectations-of-reviewers-review-latency) and must go above and beyond to promote a collaborative, respectful community.
82
82
When reviewing PRs from others [The Gentle Art of Patch Review](http://sage.thesharps.us/2014/09/01/the-gentle-art-of-patch-review/) suggests an iterative series of focuses which is designed to lead new contributors to positive collaboration without inundating them initially with nuances:
0 commit comments