Skip to content

Commit bad837c

Browse files
authored
Merge pull request #7576 from liggitt/api-project
Update API review project links
2 parents 2b13585 + 057f72c commit bad837c

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

sig-architecture/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ Establishing and documenting conventions for system and user-facing APIs, define
125125
* [API Review process](https://github.com/kubernetes/community/blob/master/sig-architecture/api-review-process.md)
126126
* [Deprecation policy](https://kubernetes.io/docs/reference/deprecation-policy/)
127127

128-
Please see the [API Reviews](https://github.com/orgs/kubernetes/projects/13) tracking board to follow the work of this sub-project. Please reach out to folks in the [OWNERS](https://git.k8s.io/design-proposals-archive/architecture/OWNERS) file if you are interested in joining this effort.
128+
Please see the [API Reviews](https://github.com/orgs/kubernetes/projects/169) tracking board to follow the work of this sub-project. Please reach out to folks in the [OWNERS](https://git.k8s.io/design-proposals-archive/architecture/OWNERS) file if you are interested in joining this effort.
129129

130130
## Enhancement Proposals
131131

sig-architecture/annual-report-2020.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151

5252
- For the enhancements subproject, all owners are all active.
5353

54-
- For the API review subproject, there are no standing meetings. The subproject coordinates via a [project board](https://github.com/orgs/kubernetes/projects/13) and [mailing list](https://groups.google.com/g/kubernetes-api-reviewers).
54+
- For the API review subproject, there are no standing meetings. The subproject coordinates via a [project board](https://github.com/orgs/kubernetes/projects/169) and [mailing list](https://groups.google.com/g/kubernetes-api-reviewers).
5555

5656
- For the code organization subproject, @dims and @liggitt run regular meetings and review PRs and issues, pulling in other owners as needed.
5757

sig-architecture/annual-report-2021.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ Continuing:
153153
- API guidance updates
154154
- [Object references](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#object-references), including cross-namespace references from namespaced objects
155155
- [Spec and Status](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#spec-and-status) ([#5842](https://github.com/kubernetes/community/pull/5842))
156-
- 114 [API reviews completed](https://github.com/orgs/kubernetes/projects/13) in 2021 (30 for v1.21, 45 for v1.22, 39 for v1.23)
156+
- 114 [API reviews completed](https://github.com/orgs/kubernetes/projects/169) in 2021 (30 for v1.21, 45 for v1.22, 39 for v1.23)
157157
- Each SIG can identify 2-3 people to be involved in API reviews - https://github.com/kubernetes/kubernetes/blob/v1.23.0/OWNERS_ALIASES#L451-L452
158158
- [Conformance Definition](https://github.com/kubernetes/community/tree/master/sig-architecture#conformance-definition-1)
159159
- We started 2021 with 128 endpoints remaining without conformance test.(69.13% conformance tested)

sig-architecture/api-review-process.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,14 @@ Voluntary reviews apply towards non-core APIs that do not meet the [mandatory](#
7878
1. Request an API review for a PR or issue in the kubernetes org by adding the `api-review` label with a `/label api-review` comment (requests can be cancelled with a `/remove-label api-review` comment)
7979
* If this is a review of a PR implementing an already-reviewed design/KEP, reference the approved KEP and note any differences between the approved design and the implementation.
8080

81-
2. API reviews are tracked in a project board at https://github.com/orgs/kubernetes/projects/13
81+
2. API reviews are tracked in a project board at https://github.com/orgs/kubernetes/projects/169
8282
* Github query for requested reviews not yet in the project:
83-
* [`is:open org:kubernetes label:api-review -project:kubernetes/13`](https://github.com/search?q=is%3Aopen+org%3Akubernetes+label%3Aapi-review+-project%3Akubernetes%2F13)
83+
* [`is:open org:kubernetes label:api-review -project:kubernetes/169`](https://github.com/search?q=is%3Aopen+org%3Akubernetes+label%3Aapi-review+-project%3Akubernetes%2F169)
8484
* Github query for items in the project no longer requesting review:
85-
* [`is:open org:kubernetes -label:api-review project:kubernetes/13`](https://github.com/search?q=is%3Aopen+org%3Akubernetes+-label%3Aapi-review+project%3Akubernetes%2F13)
85+
* [`is:open org:kubernetes -label:api-review project:kubernetes/169`](https://github.com/search?q=is%3Aopen+org%3Akubernetes+-label%3Aapi-review+project%3Akubernetes%2F169)
8686
* Requests are triaged by API approvers/reviewers/moderators [regularly](#review-lifecycle-timing), and added to the project board if prereqs have been completed
8787
* As requests are added to the project board, that is reflected in the sidebar of the issue or PR, along with the current status (backlog, assigned, in progress, completed)
88-
* The API review backlog and queue is publicly visible at https://github.com/orgs/kubernetes/projects/13
88+
* The API review backlog and queue is publicly visible at https://github.com/orgs/kubernetes/projects/169
8989

9090
3. Backlog
9191
* An approver or moderator will adjust the prioritization of the issue in the backlog. Reviews are prioritized based on a number of factors:
@@ -99,14 +99,14 @@ Voluntary reviews apply towards non-core APIs that do not meet the [mandatory](#
9999
* An approver or moderator will assign an approver (or potentially aspiring reviewer - see *training reviews* below for the aspiring reviewer workflow)
100100
* Reviews are assigned based on reviewer capacity and domain knowledge
101101
* Assignment of reviewers is done on the issue/PR itself using the normal `/assign` method (works seamlessly with existing github/PR dashboard queries)
102-
* All API reviews assigned to an individual can be viewed in the project board ([example](https://github.com/orgs/kubernetes/projects/13/?card_filter_query=assignee%3Aliggitt)), for visibility on status, order, and reviewer load
102+
* All API reviews assigned to an individual can be viewed in the project board ([example](https://github.com/orgs/kubernetes/projects/169/views/3?filterQuery=assignee%3Aliggitt)), for visibility on status, order, and reviewer load
103103

104104
5. In Progress / Approved / Changes Requested / Rejected
105105
* Reviews proceed like a normal KEP or PR review. Possible outcomes:
106106
* Approval:
107107
* Implementation PRs are tagged with `/lgtm /approve` and merged normally
108108
* KEP PRs containing API designs can also be tagged with `/lgtm /approve`, but should explicitly note if API approval is being given. This approval should be linked to when later requesting review of the implementation PR, and should limit the scope of the implementation review to differences between the approved design and final implementation, problems encountered during implementation, and correctness of the implementation.
109-
* The approved issue is archived in the review project board, and the `api-review` label is removed.
109+
* The approved issue is archived in the review project board.
110110
* Changes requested:
111111
* Comments or questions are left on the PR or issue, and the reviewer notifies the submitter
112112
* The reviewer moves the issue to "Changes Requested" in the review project board

0 commit comments

Comments
 (0)