Skip to content

Commit be17547

Browse files
authored
Merge pull request #5706 from SergeyKanzhelev/patch-4
A note on CP reviews
2 parents 38dc147 + 33f4ce6 commit be17547

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

contributors/devel/sig-release/cherry-picks.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,16 @@ pull requests on the `master` branch in that they:
121121

122122
- Are by default expected to be `kind/bug` and `priority/critical-urgent`.
123123

124+
- The original change to the `master` branch is expected to be merged for
125+
some time and no related CI failures or test flakiness must be discovered.
126+
127+
- The easy way to compare changes from the original change and cherry-pick
128+
is to compare PRs `.patch` files. To generate the patch from
129+
PR, just add the `.patch` to PR url. For example, for PR #100972 in
130+
kubernetes repositry, ptach can be downloaded following this URL:
131+
132+
`https://github.com/kubernetes/kubernetes/pull/100972.patch`
133+
124134
- Milestones must be set on the PR reflecting the milestone for the target
125135
release branch (for example, milestone v1.11 for a cherry pick onto branch
126136
`release-1.11`). This is normally done for you by automation.

0 commit comments

Comments
 (0)