Skip to content

Commit c7fffe8

Browse files
authored
Merge pull request #5917 from logicalhan/guidelines
amend instrumentation cardinality guidelines to explicitly advise against using namespaces
2 parents ebf05b5 + c5df2e6 commit c7fffe8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

contributors/devel/sig-instrumentation/instrumentation.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,8 @@ constantly create new ones, with new names. However, they have
160160
a reasonable upper bound for a given size of infrastructure they refer to and
161161
its typical frequency of changes.
162162

163-
In general, “external” labels like pod or node name do not belong in the
164-
instrumentation itself. They are to be attached to metrics by the collecting
163+
In general, “external” labels like pod name, node name (any object name), & namespace do not belong in the
164+
instrumentation itself (the exception being kube-state-metrics). They are to be attached to metrics by the collecting
165165
system that has the external knowledge ([blog post](https://www.robustperception.io/target-labels-are-for-life-not-just-for-christmas/)).
166166

167167
## Normalization

0 commit comments

Comments
 (0)