Skip to content

Commit caecdf5

Browse files
dashpoletariq1890
andauthored
Apply suggestions from code review
Co-authored-by: Tariq Ibrahim <[email protected]>
1 parent 89ed48f commit caecdf5

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

contributors/devel/sig-instrumentation/instrumentation.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,14 +118,14 @@ in kubectl, i.e. daemon sets are `daemonset` rather than `daemon_set`.
118118

119119
### Exception for object state metrics
120120

121-
One exception to the component prefix rule is for metrics collected about
122-
the state of kubernetes objects. From users' perspective, controllers are an
121+
One exception to the component prefix rule is for metrics derived from
122+
the state of Kubernetes objects. From the users' perspective, controllers are an
123123
implementation detail of object reconciliation. The collection of controllers
124-
which comprise a working kuberntes cluster is viewed as a single system which
124+
which comprise a working Kubernetes cluster is viewed as a single system which
125125
drives objects towards their specified desired state. Metrics concerning a
126-
given object should be easily discoverable and compareable even when they are
126+
given object should be easily discoverable and comparable even when they are
127127
produced by different controllers. Metrics describing the state of a built-in
128-
kubernetes object take the form:
128+
Kubernetes object take the form:
129129

130130
```
131131
kube_<kind>_<metric>
@@ -235,4 +235,3 @@ metric could look as follows:
235235
```
236236
kube_pod_restarts and on(namespace, pod) kube_pod_info{uuid=”ABC”}
237237
```
238-

0 commit comments

Comments
 (0)