Skip to content

Commit ccf7baf

Browse files
authored
Merge pull request #6248 from claudiubelu/remove-windows-docker-tag
Removes [Exclude:WindowsDocker] test tag
2 parents 7a5666c + a48453e commit ccf7baf

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

contributors/devel/sig-architecture/conformance-tests.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,9 @@ implicitly by Docker or ContainerD, not by the kubelet. Do not check properties
134134
- Storage
135135
- File permissions cannot be set on volumes. Tests using `DefaultMode` or `Mode` and checking the resulting permissions will fail.
136136
- Only NTFS volumes are supported. Volume mounts specifying other filesystems (ext4, xfs) or mediums (memory) are not supported
137-
- Mappings of individual files are not supported. Tests which are mounting or expecting such files to be mounted (including /etc/hosts, /etc/resolv.conf, /dev/termination-log) will fail.
138137
- Bidirectional mount propagation, specifically propagating mounts from a container to host, does not work.
139138
- Networking
140-
- Pods set `HostNetwork=true`. Is not supported on Windows, and the Pod will not start.
139+
- Pods set `HostNetwork=true`. For Windows, this can only be enabled for Windows Privileged Containers. In other cases, the Pod will not start.
141140
- Network and DNS settings must be passed through CNI. Windows does not use `/etc/resolv.conf`, so tests should not rely on reading that file to check DNS settings.
142141
- If you to check network settings such as dns search lists, please use [agnhost](https://github.com/kubernetes/kubernetes/tree/master/test/images/agnhost) to output needed data from the container.
143142
- Windows treats all DNS lookups with a `.` to be FQDN, not PQDN. For example `kubernetes` will resolve as a PQDN,

contributors/devel/sig-testing/e2e-tests.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -576,13 +576,6 @@ to be eligible for this tag. This tag does not supersed any other labels.
576576
(e.g.: seLinuxOptions) or is unable to run on Windows nodes, it is labeled
577577
`[LinuxOnly]`. When using Windows nodes, this tag should be added to the
578578
`skip` argument.
579-
- `[Exclude:WindowsDocker]`: Windows Kubelet supports both Docker and Containerd,
580-
however, Containerd has a few additional features (e.g.: Single file mapping). This
581-
means that there are tests that can run on Containerd Windows nodes, but they will
582-
fail on Docker Windows nodes. These tests are labeled `[Exclude:WindowsDocker]`, thus,
583-
when using Windows Docker nodes, this tag should be added to the `skip` argument. This
584-
tag is intended to be removed when Containerd becomes the default for Windows nodes in
585-
1.24 (https://github.com/kubernetes/community/issues/6123)
586579
587580
- The following tags are not considered to be exhaustively applied, but are
588581
intended to further categorize existing `[Conformance]` tests, or tests that are

0 commit comments

Comments
 (0)