Skip to content

Commit ed6f218

Browse files
authored
Added link to best practices section
Added a link to, 'How to Make Your Code Reviewer Fall in Love With You,' by Michael Lynch
1 parent 599b754 commit ed6f218

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

contributors/guide/contributing.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,11 @@ Note: if your pull request isn't getting enough attention, you can use the [#pr-
9494
- Make sure you don't include `@mentions` or `fixes` keywords in your git commit messages. These should be included in the PR body instead.
9595
- When you make a PR for small change (such as fixing a typo, style change, or grammar fix), please squash your commits so that we can maintain a cleaner git history.
9696
- Make sure you include a clear and detailed PR description explaining the reasons for the changes, and ensuring there is sufficient information for the reviewer to understand your PR.
97-
- Additional Readings :
97+
- Additional Readings:
9898
- [chris.beams.io/posts/git-commit/](https://chris.beams.io/posts/git-commit/)
99-
- [github.com/blog/1506-closing-issues-via-pull-requests ](https://github.com/blog/1506-closing-issues-via-pull-requests )
100-
- [davidwalsh.name/squash-commits-git ](https://davidwalsh.name/squash-commits-git )
99+
- [github.com/blog/1506-closing-issues-via-pull-requests ](https://github.com/blog/1506-closing-issues-via-pull-requests)
100+
- [davidwalsh.name/squash-commits-git ](https://davidwalsh.name/squash-commits-git)
101+
- [https://mtlynch.io/code-review-love/](https://mtlynch.io/code-review-love/)
101102

102103
## Testing
103104

0 commit comments

Comments
 (0)