Skip to content

Commit eec1ce7

Browse files
authored
Merge pull request #5486 from ehashman/fatal-logs
Add guidance for fatal exit codes
2 parents f0d4b23 + 48a8c87 commit eec1ce7

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

contributors/devel/sig-instrumentation/migration-to-structured-logging.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,8 @@ origin point. For expected errors (`errors` that can happen during routine opera
150150
Use of Fatal should be discouraged and it's not available in new functions. Instead of depending on the logger to exit
151151
the process, you should call `os.Exit()` yourself.
152152

153+
Fatal calls use a default exit code of 255. When migrating, please use an exit code of 1 and include an "ACTION REQUIRED:" release note.
154+
153155
## Remove string formatting from log message
154156

155157
With structured logging, log messages are no longer formatted, leaving argument marshalling up to the logging client

0 commit comments

Comments
 (0)