Skip to content

Commit fcd8fa1

Browse files
aojeaBenTheElder
andauthored
Update contributors/devel/sig-testing/testing-strategy.md
Co-authored-by: Benjamin Elder <[email protected]>
1 parent 6401797 commit fcd8fa1

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

contributors/devel/sig-testing/testing-strategy.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@ healthy: Blocking and Informing.
2929
If your feature or area is critical for the release please follow the instructions provided in https://github.com/kubernetes/sig-release/blob/master/release-blocking-jobs.md to promote your periodic jobs to be Blocking or Informing.
3030

3131
A condition necessary for Presubmit Blocking jobs is to be also a Release Blocking jobs.
32+
Presubmit Blocking jobs should be even faster than Release Blocking jobs (under one hour, preferably under 30 minutes).
33+
Jobs should only be promoted to presubmit blocking if we are **frequently** identifying bugs only after they disrupt the release blocking jobs. A few times per release is not sufficient, you can use testgrid to bisect the commits that merged between pass / fail and revert or fix the relevant PR.
34+
35+
Presubmit blocking jobs are much more expensive to run than release blocking jobs because they must run on every pushed PR, not just merged code, and issues with them disrupt ALL contributors, so we do not add presubmit blocking jobs lightly.
3236

3337
### Mitigating E2E Test Flakiness
3438

0 commit comments

Comments
 (0)