Skip to content

Commit 1d603a4

Browse files
committed
Assume valid when name validation errors.
Addresses #373
1 parent 8995ee4 commit 1d603a4

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/app/frontend/deploy/uniquename_directive.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,11 @@ function validate(name, namespace, resource, q) {
6868
deferred.reject();
6969
}
7070
},
71-
() => { deferred.reject(); });
71+
() => {
72+
// On error assume that the name is valid. If it is not, the error is caught later in the
73+
// deploy pipeline.
74+
deferred.resolve();
75+
});
7276

7377
return deferred.promise;
7478
}

src/test/frontend/deploy/uniquename_directive_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,6 @@ describe('Unique name directive', () => {
8686
httpBackend.when('POST', 'api/v1/appdeployments/validate/name').respond(503, '');
8787
httpBackend.flush();
8888
expect(elem.classList).not.toContain('ng-pending');
89-
expect(elem.classList).toContain('ng-invalid');
89+
expect(elem.classList).toContain('ng-valid');
9090
});
9191
});

0 commit comments

Comments
 (0)