Skip to content

Commit 1f79049

Browse files
committed
Merge pull request #359 from bryk/sauce-fix
Fix travis setup for pull requests from form
2 parents 995036f + f25ad50 commit 1f79049

File tree

4 files changed

+12
-2
lines changed

4 files changed

+12
-2
lines changed

.travis.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,14 @@ addons:
3636
username: k8s-dashboard-ci
3737
access_key: "18b7e71b-60e9-4177-9a7f-e769977dbb39"
3838

39+
before_script:
40+
# Prepare environment for the Chrome browser. This is required for PRs from forks where
41+
# tests do not run on Saucelabs.
42+
# TODO(bryk): Make tests run only on Saucelabs.
43+
- export CHROME_BIN=chromium-browser
44+
- export DISPLAY=:99.0
45+
- sh -e /etc/init.d/xvfb start
46+
3947
# Docker is required to set up a simple, single node Kubernetes cluster.
4048
# Local Docker-based cluster is the simplest way to create kubernetes on the host machine.
4149
services:

build/protractor.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ function createConfig() {
6565
];
6666

6767
} else {
68-
config.capabilities = {'browserName': 'chrome'};
68+
config.capabilities = {'browserName': 'firefox'};
6969
}
7070

7171
return config;

build/test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,8 @@ gulp.task('integration-test:prod', ['serve:prod', 'webdriver-update'], runProtra
138138
* Runs application integration tests. Uses production version of the application.
139139
*/
140140
gulp.task(
141-
'local-cluster-integration-test:prod', ['serve:prod', 'local-up-cluster'], runProtractorTests);
141+
'local-cluster-integration-test:prod', ['serve:prod', 'local-up-cluster', 'webdriver-update'],
142+
runProtractorTests);
142143

143144
/**
144145
* Downloads and updates webdriver. Required to keep it up to date.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
"karma-browserify": "~5.0.1",
5454
"karma-chrome-launcher": "~0.2.2",
5555
"karma-coverage": "~0.5.3",
56+
"karma-firefox-launcher": "^0.1.7",
5657
"karma-jasmine": "~0.3.6",
5758
"karma-ng-html2js-preprocessor": "~0.2.0",
5859
"karma-sauce-launcher": "^0.3.0",

0 commit comments

Comments
 (0)