Skip to content

Commit 4eecac7

Browse files
committed
Remove sauce access keys from travis config
With that tests on sauce will not run on devs' forks, which will hopefully make them less flaky. I've added the key to travis config variable and made publicly availible. Partially addresses: #494
1 parent 9ae1dab commit 4eecac7

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

.travis.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ node_js:
3232

3333
addons:
3434
# Run tests that require a browser on SauceLabs CI provider. Learn more at: https://saucelabs.com
35-
sauce_connect:
36-
username: k8s-dashboard-ci
37-
access_key: "18b7e71b-60e9-4177-9a7f-e769977dbb39"
35+
sauce_connect: true
3836

3937
before_script:
4038
# Prepare environment for the Chrome browser. This is required for PRs from forks where

build/conf.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,8 @@ export default {
143143
/**
144144
* Whether to use sauce labs for running tests that require a browser.
145145
*/
146-
useSauceLabs:
147-
!!process.env.SAUCE_USERNAME && !!process.env.SAUCE_ACCESS_KEY && !!process.env.TRAVIS,
146+
useSauceLabs: !!process.env.SAUCE_USERNAME && !!process.env.SAUCE_ACCESS_KEY &&
147+
!!process.env.TRAVIS && process.env.TRAVIS_PULL_REQUEST === 'false',
148148
},
149149

150150
/**

0 commit comments

Comments
 (0)