Skip to content

Commit 5b31f2f

Browse files
committed
Merge pull request #594 from maciaszczykm/sorting-fix
Fix table sorting
2 parents 8dcf5a3 + 72321ac commit 5b31f2f

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/app/frontend/replicationcontrollerdetail/replicationcontrollerdetail.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ <h1 flex="auto" class="md-title kd-replicationcontrollerdetail-app-name">
6060
</th>
6161
<th class="kd-replicationcontrollerdetail-table-header">
6262
<kd-sorted-header currently-selected-column="ctrl.sortPodsBy"
63-
currently-selected-order="ctrl.podsOrder" column-name="status"
63+
currently-selected-order="ctrl.podsOrder" column-name="podPhase"
6464
tooltip="Status of the pod">
6565
Status
6666
</kd-sorted-header>
@@ -219,7 +219,7 @@ <h1 flex="auto" class="md-title kd-replicationcontrollerdetail-app-name">
219219
<th class="kd-replicationcontrollerdetail-table-header">
220220
<kd-sorted-header currently-selected-column="ctrl.sortEventsBy"
221221
currently-selected-order="ctrl.eventsOrder"
222-
column-name="['sourceComponent','sourceHost']"
222+
column-name="[sourceComponent,sourceHost]"
223223
tooltip="Source of the event, details of component and host">
224224
Source
225225
</kd-sorted-header>

src/app/frontend/replicationcontrollerdetail/sortedheader_controller.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ export default class SortedHeaderController {
4040
this.tooltip;
4141

4242
/**
43-
* Name of current header column. Initialized from the scope (read-only).
43+
* Name of current header column. Must match at least one of sorted object members. Initialized
44+
* from the scope (read-only).
4445
* @export {string}
4546
*/
4647
this.columnName;

0 commit comments

Comments
 (0)