Skip to content

Commit 6c183f5

Browse files
committed
Fix a bug where deployment details page crashed
We used status instead of statusInfo
1 parent 6d72bee commit 6c183f5

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/app/externs/backendapi.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ backendApi.DeploymentInfo;
297297
* objectMeta: !backendApi.ObjectMeta,
298298
* typeMeta: !backendApi.TypeMeta,
299299
* selector: !Array<backendApi.Label>,
300-
* status: !backendApi.DeploymentInfo,
300+
* statusInfo: !backendApi.DeploymentInfo,
301301
* strategy: !string,
302302
* minReadySeconds: !number,
303303
* rollingUpdateStrategy: !backendApi.RollingUpdateStrategy,

src/app/frontend/deploymentdetail/deploymentinfo_component.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,19 +74,19 @@ function i18n(deployment) {
7474
/** @export {string} @desc The message says that that many replicas were updated in the deployment
7575
(deployment details page). */
7676
MSG_DEPLOYMENT_DETAIL_REPLICAS_UPDATED_LABEL:
77-
goog.getMsg('{$replicas} updated', {'replicas': deployment.status.updated}),
77+
goog.getMsg('{$replicas} updated', {'replicas': deployment.statusInfo.updated}),
7878
/** @export {string} @desc The message says that that many replicas (in total) are in the deployment
7979
(deployment details page). */
8080
MSG_DEPLOYMENT_DETAIL_REPLICAS_TOTAL_LABEL:
81-
goog.getMsg('{$replicas} total', {'replicas': deployment.status.replicas}),
81+
goog.getMsg('{$replicas} total', {'replicas': deployment.statusInfo.replicas}),
8282
/** @export {string} @desc The message says that that many replicas are available in the deployment
8383
(deployment details page). */
8484
MSG_DEPLOYMENT_DETAIL_REPLICAS_AVAILABLE_LABEL:
85-
goog.getMsg('{$replicas} available', {'replicas': deployment.status.available}),
85+
goog.getMsg('{$replicas} available', {'replicas': deployment.statusInfo.available}),
8686
/** @export {string} @desc The message says that that many replicas are unavailable in the deployment
8787
(deployment details page). */
8888
MSG_DEPLOYMENT_DETAIL_REPLICAS_UNAVAILABLE_LABEL:
89-
goog.getMsg('{$replicas} unavailable', {'replicas': deployment.status.unavailable}),
89+
goog.getMsg('{$replicas} unavailable', {'replicas': deployment.statusInfo.unavailable}),
9090
/** @export {string} @desc The message says how many replicas are allowed to be unavailable during an
9191
update in the deployment (deployment details page). */
9292
MSG_DEPLOYMENT_DETAIL_MAX_UNAVAILABLE_LABEL: goog.getMsg(

src/test/frontend/deploymentdetail/deploymentinfo_component_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe('Deployment Info controller', () => {
1313
angular.mock.inject(($componentController, $rootScope) => {
1414
ctrl = $componentController('kdDeploymentInfo', {$scope: $rootScope}, {
1515
deployment: {
16-
status: {
16+
statusInfo: {
1717
updated: 0,
1818
replicas: 0,
1919
available: 0,

0 commit comments

Comments
 (0)