Fix issue with edit dialog on details page (#874)

Author: Sebastian Florek

i18n/messages-en.xtb

@@ -363,4 +363,5 @@
 	<translation id="8808405168042160441" key="MSG_RC_LIST_EDIT_POD_COUNT_ACTION" source="/usr/local/google/home/bryk/src/github.com/dashboard/.tmp/serve/app-dev.js" desc="Action 'Edit Pod Count' on the drop down menu for a single replication controller (replication controller list page).">Scale</translation>
 	<translation id="1811662550159188281" key="MSG_POD_LIST_CPU_USAGE_LABEL" source="/usr/local/google/home/bryk/src/github.com/dashboard/.tmp/serve/app-dev.js" desc="Label which appears as a column label in the table of pods">CPU (cores)</translation>
 	<translation id="9149343004693743620" key="MSG_POD_LIST_MEMORY_USAGE_LABEL" source="/usr/local/google/home/bryk/src/github.com/dashboard/.tmp/serve/app-dev.js" desc="Label which appears as a column label in the table of pods">Memory (bytes)</translation>
+	<translation id="2278267472990776370" key="MSG_JOB_DETAIL_JOB_LABEL" source="/home/floreks/Projects/dashboard/.tmp/serve/app-dev.js" desc="Label 'Job' which appears at the top of the dialog, opened from a job details page.">Job</translation>
 </translationbundle>

i18n/messages-ja.xtb

@@ -363,4 +363,5 @@
 	<translation id="8808405168042160441" key="MSG_RC_LIST_EDIT_POD_COUNT_ACTION" source="/usr/local/google/home/bryk/src/github.com/dashboard/.tmp/serve/app-dev.js" desc="Action 'Edit Pod Count' on the drop down menu for a single replication controller (replication controller list page).">Scale</translation>
 	<translation id="1811662550159188281" key="MSG_POD_LIST_CPU_USAGE_LABEL" source="/usr/local/google/home/bryk/src/github.com/dashboard/.tmp/serve/app-dev.js" desc="Label which appears as a column label in the table of pods">CPU (cores)</translation>
 	<translation id="9149343004693743620" key="MSG_POD_LIST_MEMORY_USAGE_LABEL" source="/usr/local/google/home/bryk/src/github.com/dashboard/.tmp/serve/app-dev.js" desc="Label which appears as a column label in the table of pods">Memory (bytes)</translation>
+	<translation id="2278267472990776370" key="MSG_JOB_DETAIL_JOB_LABEL" source="/home/floreks/Projects/dashboard/.tmp/serve/app-dev.js" desc="Label 'Job' which appears at the top of the dialog, opened from a job details page.">Job</translation>
 </translationbundle>

src/app/backend/resource/common/types.go

@@ -129,7 +129,7 @@ var kindToAPIMapping = map[string]struct {
 	ResourceKindReplicationController: {"replicationcontrollers", ClientTypeDefault},
 	ResourceKindDeployment:            {"deployments", ClientTypeExtensionClient},
 	ResourceKindReplicaSet:            {"replicasets", ClientTypeExtensionClient},
-	ResourceKindDaemonSet:             {"daemonsets", ClientTypeDefault},
+	ResourceKindDaemonSet:             {"daemonsets", ClientTypeExtensionClient},
 	ResourceKindPetSet:                {"petsets", ClientTypeAppsClient},
 	ResourceKindJob:                   {"jobs", ClientTypeBatchClient},
 	ResourceKindNode:                  {"nodes", ClientTypeDefault},

src/app/frontend/jobdetail/actionbar.html

@@ -0,0 +1,21 @@
+<!--
+Copyright 2015 Google Inc. All Rights Reserved.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+<kd-actionbar-detail-buttons
+        resource-kind-name="{{::$ctrl.i18n.MSG_JOB_DETAIL_JOB_LABEL}}"
+        type-meta="$ctrl.details.typeMeta"
+        object-meta="$ctrl.details.objectMeta">
+</kd-actionbar-detail-buttons>

src/app/frontend/jobdetail/actionbar_controller.js

@@ -0,0 +1,36 @@
+// Copyright 2015 Google Inc. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+/**
+ * @final
+ */
+export class ActionBarController {
+  /**
+   * @param {!backendApi.JobDetail} jobDetail
+   * @ngInject
+   */
+  constructor(jobDetail) {
+    /** @export {!backendApi.JobDetail} */
+    this.details = jobDetail;
+
+    /** @export */
+    this.i18n = i18n;
+  }
+}
+
+const i18n = {
+  /** @export {string} @desc Label 'Job' which appears at the top of the
+   dialog, opened from a job details page. */
+  MSG_JOB_DETAIL_JOB_LABEL: goog.getMsg('Job'),
+};

src/app/frontend/jobdetail/jobdetail_stateconfig.js

@@ -16,7 +16,7 @@ import {actionbarViewName, stateName as chromeStateName} from 'chrome/chrome_sta
 import {breadcrumbsConfig} from 'common/components/breadcrumbs/breadcrumbs_service';
 import {appendDetailParamsToUrl} from 'common/resource/resourcedetail';
 import {stateName as jobList, stateUrl} from 'joblist/joblist_state';
-
+import {ActionBarController} from './actionbar_controller';
 import {JobDetailController} from './jobdetail_controller';
 import {stateName} from './jobdetail_state';
 
@@ -46,7 +46,11 @@ export default function stateConfig($stateProvider) {
         controllerAs: 'ctrl',
         templateUrl: 'jobdetail/jobdetail.html',
       },
-      [actionbarViewName]: {},
+      [actionbarViewName]: {
+        templateUrl: 'jobdetail/actionbar.html',
+        controller: ActionBarController,
+        controllerAs: '$ctrl',
+      },
     },
   });
 }

src/app/frontend/replicationcontrollerdetail/actionbar_controller.js

@@ -50,4 +50,7 @@ const i18n = {
   /** @export {string} @desc Tooltip for the 'scale' button on the action bar of a replication
       controller details view.*/
   MSG_RC_DETAIL_ACTION_BAR_EDIT_PODS_LABEL: goog.getMsg('Scale'),
+  /** @export {string} @desc Label 'Replication Controller' which appears at the top of the
+   edit dialog, opened from a replication controller details page. */
+  MSG_RC_DETAIL_REPLICATION_CONTROLLER_LABEL: goog.getMsg('Replication Controller'),
 };