Skip to content

Commit a79e7a3

Browse files
Marcin MaciaszczykMarcin Maciaszczyk
authored andcommitted
Improve tabbing
1 parent 070373e commit a79e7a3

File tree

3 files changed

+58
-28
lines changed

3 files changed

+58
-28
lines changed

src/app/frontend/chrome/chrome.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<md-content class="kd-content">
1818
<md-toolbar class="kd-toolbar">
1919
<div class="md-toolbar-tools kd-toolbar-tools">
20-
<a ui-sref="replicationcontrollers" ui-sref-opts="{ reload: true }">
20+
<a ui-sref="replicationcontrollers" ui-sref-opts="{ reload: true }" tabindex="-1">
2121
<md-icon md-svg-icon="assets/images/kubernetes-logo.svg" class="kd-toolbar-logo"></md-icon>
2222
</a>
2323
<h2>

src/app/frontend/deploy/deploy.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ <h3 class="md-headline kd-deploy-form-title">Deploy a Containerized App</h3>
3030
</md-radio-group>
3131
<kd-user-help>
3232
To learn more,
33-
<a href="http://kubernetes.github.io/docs/user-guide/ui/" target="_blank">
33+
<a href="http://kubernetes.github.io/docs/user-guide/ui/" target="_blank" tabindex="-1">
3434
take the Dashboard Tour <i class="material-icons">open_in_new</i>
3535
</a>
3636
</kd-user-help>

src/app/frontend/deploy/deployfromsettings.html

Lines changed: 56 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
<i>{{ctrl.namespace}}</i>.
3333
</ng-message>
3434
<ng-message when="pattern">
35-
Application name must start with a lowercase letter
36-
and contain only lowercase letters, numbers, and '-' between words.
35+
Application name must start with a lowercase letter and contain only lowercase letters,
36+
numbers, and '-' between words.
3737
</ng-message>
3838
<ng-message when="maxlength">
3939
Name must be up to {{ctrl.nameMaxLength}} characters long.
@@ -43,8 +43,11 @@
4343
</md-input-container>
4444

4545
<kd-user-help>
46-
An 'app' label with this value will be added to the Replication Controller and Service that get deployed.
47-
<a href="http://kubernetes.github.io/docs/user-guide/labels/" target="_blank">Learn more</a>
46+
An 'app' label with this value will be added to the Replication Controller and Service that get
47+
deployed.
48+
<a href="http://kubernetes.github.io/docs/user-guide/labels/" target="_blank" tabindex="-1">
49+
Learn more
50+
</a>
4851
</kd-user-help>
4952
</kd-help-section>
5053

@@ -56,29 +59,38 @@
5659
kd-valid-imagereference invalid-image-error-message="ctrl.containerImageErrorMessage">
5760
<ng-messages for="ctrl.form.containerImage.$error" role="alert" multiple>
5861
<ng-message when="required">Container image is required.</ng-message>
59-
<ng-message when="validImageReference">Container image is invalid: {{ ctrl.containerImageErrorMessage }}</ng-message>
62+
<ng-message when="validImageReference">
63+
Container image is invalid: {{ ctrl.containerImageErrorMessage }}
64+
</ng-message>
6065
</ng-messages>
6166
</md-input-container>
6267
<kd-user-help>
6368
Enter the URL of a public image on any registry, or a private image hosted on Docker Hub or
6469
Google Container Registry.
65-
<a href="http://kubernetes.github.io/docs/user-guide/images/" target="_blank">Learn more</a>
70+
<a href="http://kubernetes.github.io/docs/user-guide/images/" target="_blank" tabindex="-1">
71+
Learn more
72+
</a>
6673
</kd-user-help>
6774
</kd-help-section>
6875

6976
<kd-help-section>
7077
<md-input-container class="md-block">
7178
<label>Number of pods</label>
72-
<input ng-model="ctrl.replicas" type="number" required min="1" name="replicas" kd-validate="integer">
79+
<input ng-model="ctrl.replicas" type="number" required min="1" name="replicas"
80+
kd-validate="integer">
7381
<ng-messages for="ctrl.form.replicas.$error" role="alert" multiple>
7482
<ng-message when="required">Number of pods is required.</ng-message>
7583
<ng-message when="number, kdValid">Number of pods must be a positive integer.</ng-message>
7684
<ng-message when="min">Number of pods must be at least 1.</ng-message>
7785
</ng-messages>
7886
</md-input-container>
7987
<kd-user-help>
80-
A Replication Controller will be created to maintain the desired number of pods across your cluster.
81-
<a href="http://kubernetes.github.io/docs/user-guide/replication-controller/" target="_blank">Learn more</a>
88+
A Replication Controller will be created to maintain the desired number of pods across your
89+
cluster.
90+
<a href="http://kubernetes.github.io/docs/user-guide/replication-controller/" target="_blank"
91+
tabindex="-1">
92+
Learn more
93+
</a>
8294
</kd-user-help>
8395
</kd-help-section>
8496

@@ -92,7 +104,9 @@
92104
<span ng-if="ctrl.name">
93105
The internal DNS name for this Service will be: <span class="kd-emphasized">{{ctrl.name}}</span>.
94106
</span>
95-
<a href="http://kubernetes.github.io/docs/user-guide/services/" target="_blank">Learn more</a>
107+
<a href="http://kubernetes.github.io/docs/user-guide/services/" target="_blank" tabindex="-1">
108+
Learn more
109+
</a>
96110
</kd-user-help>
97111
</kd-help-section>
98112

@@ -111,8 +125,8 @@
111125
<textarea ng-model="ctrl.description"></textarea>
112126
</md-input-container>
113127
<kd-user-help>
114-
The description will be added as an annotation to the Replication Controller and displayed in the
115-
application's details.
128+
The description will be added as an annotation to the Replication Controller and displayed in
129+
the application's details.
116130
</kd-user-help>
117131
</kd-help-section>
118132

@@ -125,14 +139,17 @@
125139
<div flex="40">Value</div>
126140
</div>
127141
<div ng-repeat="label in ctrl.labels">
128-
<kd-deploy-label layout="row" flex="auto" label="label" labels="ctrl.labels"></kd-deploy-label>
142+
<kd-deploy-label layout="row" flex="auto" label="label" labels="ctrl.labels">
143+
</kd-deploy-label>
129144
</div>
130145
</div>
131146

132147
<kd-user-help>
133-
The specified labels will be applied to the created Replication Controller, Service (if any) and Pods.
134-
Common labels include release, environment, tier, partition and track.
135-
<a href="http://kubernetes.github.io/docs/user-guide/labels/" target="_blank">Learn more</a>
148+
The specified labels will be applied to the created Replication Controller, Service (if any)
149+
and Pods. Common labels include release, environment, tier, partition and track.
150+
<a href="http://kubernetes.github.io/docs/user-guide/labels/" target="_blank" tabindex="-1">
151+
Learn more
152+
</a>
136153
</kd-user-help>
137154
</kd-help-section>
138155

@@ -150,7 +167,9 @@
150167
</md-input-container>
151168
<kd-user-help>
152169
Namespaces let you partition resources into logically named groups.
153-
<a href="http://kubernetes.github.io/docs/admin/namespaces/" target="_blank">Learn more</a>
170+
<a href="http://kubernetes.github.io/docs/admin/namespaces/" target="_blank" tabindex="-1">
171+
Learn more
172+
</a>
154173
</kd-user-help>
155174
</kd-help-section>
156175

@@ -169,7 +188,9 @@
169188
<kd-user-help>
170189
The specified image could require a pull secret credential if it is private. You may choose an
171190
existing secret or create a new one.
172-
<a href="http://kubernetes.github.io/docs/user-guide/secrets/" target="_blank">Learn more</a>
191+
<a href="http://kubernetes.github.io/docs/user-guide/secrets/" target="_blank" tabindex="-1">
192+
Learn more
193+
</a>
173194
</kd-user-help>
174195
</kd-help-section>
175196

@@ -195,7 +216,9 @@
195216
</div>
196217
<kd-user-help>
197218
You can specify minimum CPU and memory requirements for the container.
198-
<a href="http://kubernetes.io/v1.1/docs/admin/limitrange/" target="_blank">Learn more</a>
219+
<a href="http://kubernetes.io/v1.1/docs/admin/limitrange/" target="_blank" tabindex="-1">
220+
Learn more
221+
</a>
199222
</kd-user-help>
200223
</kd-help-section>
201224

@@ -214,7 +237,10 @@
214237
<kd-user-help>
215238
By default, your containers run the selected image's default entrypoint command. You can
216239
use the command options to override the default.
217-
<a href="http://kubernetes.github.io/docs/user-guide/containers/" target="_blank">Learn more</a>
240+
<a href="http://kubernetes.github.io/docs/user-guide/containers/" target="_blank"
241+
tabindex="-1">
242+
Learn more
243+
</a>
218244
</kd-user-help>
219245
</kd-help-section>
220246

@@ -226,7 +252,10 @@
226252
</div>
227253
<kd-user-help>
228254
Processes in privileged containers are equivalent to processes running as root on the host.
229-
<a href="http://kubernetes.github.io/docs/user-guide/pods/#privileged-mode-for-pod-containers" target="_blank">Learn more</a>
255+
<a href="http://kubernetes.github.io/docs/user-guide/pods/#privileged-mode-for-pod-containers"
256+
target="_blank" tabindex="-1">
257+
Learn more
258+
</a>
230259
</kd-user-help>
231260
</kd-help-section>
232261

@@ -236,19 +265,20 @@
236265
<kd-user-help>
237266
Environment variables available for use in the container. Values can reference other variables
238267
using $(VAR_NAME) syntax.
239-
<a href="http://kubernetes.github.io/docs/docs/design/expansion/" target="_blank">Learn more</a>
268+
<a href="http://kubernetes.github.io/docs/docs/design/expansion/" target="_blank"
269+
tabindex="-1">
270+
Learn more
271+
</a>
240272
</kd-user-help>
241273
</kd-help-section>
242274
</div>
243275

244276
<!-- show/hide advanced options toggle -->
245277
<md-button class="md-primary kd-deploy-moreoptions-button" type="button"
246-
ng-click="ctrl.switchMoreOptions()"
247-
ng-hide="ctrl.isMoreOptionsEnabled()">
278+
ng-click="ctrl.switchMoreOptions()" ng-hide="ctrl.isMoreOptionsEnabled()">
248279
<md-icon>arrow_drop_down</md-icon>show advanced options
249280
</md-button>
250281
<md-button class="md-primary kd-deploy-moreoptions-button" type="button"
251-
ng-click="ctrl.switchMoreOptions()"
252-
ng-show="ctrl.isMoreOptionsEnabled()">
282+
ng-click="ctrl.switchMoreOptions()" ng-show="ctrl.isMoreOptionsEnabled()">
253283
<md-icon>arrow_drop_up</md-icon>hide advanced options
254284
</md-button>

0 commit comments

Comments
 (0)