Skip to content

Commit c9c1bc1

Browse files
Sebastian FlorekSebastian Florek
authored andcommitted
Merge pull request #491 from floreks/logs-fix
Fixed styling issues on logs page and made it more responsive
2 parents 8cfcf64 + 481bc36 commit c9c1bc1

File tree

4 files changed

+94
-27
lines changed

4 files changed

+94
-27
lines changed

.sass-lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ rules:
4141
no-empty-rulesets: 2
4242
no-extends: 0
4343
no-ids: 2
44-
no-important: 2
44+
no-important: 0
4545
no-invalid-hex: 2
4646
no-mergeable-selectors: 2
4747
no-misspelled-properties: 2

src/app/frontend/chrome/chrome.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
.kd-toolbar {
2424
box-shadow: $whiteframe-shadow-1dp;
2525
height: $toolbar-height-size-base;
26-
position: fixed;
26+
position: fixed !important;
2727
top: 0;
2828
}
2929

src/app/frontend/logs/logstoolbar/logstoolbar.html

Lines changed: 65 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -14,38 +14,78 @@
1414
limitations under the License.
1515
-->
1616

17-
<div layout="row" layout-wrap layout-margin layout-align="center center">
18-
<span flex="10"></span>
19-
20-
<div layout="row" layout-wrap layout-margin layout-align="center center">
21-
<span class="kd-logs-toolbar-text">Logs from pod:</span>
22-
<md-select class="kd-logs-toolbar-select" aria-label="Logs from pod" ng-model="ctrl.pod"
23-
md-on-close="ctrl.onPodChange(ctrl.pod.name)"
24-
required>
25-
<md-option ng-repeat="item in ctrl.pods" ng-value="item">
26-
<span class="kd-logs-toolbar-text">{{item.name}}</span>
27-
</md-option>
28-
</md-select>
29-
<span class="kd-logs-toolbar-text">Container:</span>
30-
<md-select class="kd-logs-toolbar-select" aria-label="Containers" ng-model="ctrl.container"
31-
md-on-close="ctrl.onContainerChange(ctrl.container.name)"
32-
required>
33-
<md-option ng-repeat="item in ctrl.containers" ng-value="item">
34-
<span class="kd-logs-toolbar-text">{{item.name}}</span>
35-
</md-option>
36-
</md-select>
37-
</div>
38-
<span class="kd-logs-toolbar-text" flex="auto" >
17+
<div layout="row" hide show-gt-sm layout-margin layout-align="center center"
18+
class="kd-logs-toolbar">
19+
<span class="kd-logs-toolbar-text">Pod:</span>
20+
<md-select class="kd-logs-toolbar-select" aria-label="Logs from pod" ng-model="ctrl.pod"
21+
md-on-close="ctrl.onPodChange(ctrl.pod.name)"
22+
required>
23+
<md-option ng-repeat="item in ctrl.pods" ng-value="item">
24+
<span class="kd-logs-toolbar-text">{{item.name}}</span>
25+
</md-option>
26+
</md-select>
27+
28+
<span class="kd-logs-toolbar-text">Container:</span>
29+
<md-select class="kd-logs-toolbar-select" aria-label="Containers" ng-model="ctrl.container"
30+
md-on-close="ctrl.onContainerChange(ctrl.container.name)"
31+
required>
32+
<md-option ng-repeat="item in ctrl.containers" ng-value="item">
33+
<span class="kd-logs-toolbar-text">{{item.name}}</span>
34+
</md-option>
35+
</md-select>
36+
37+
<span class="kd-logs-toolbar-text" flex="auto">
3938
<span ng-if="ctrl.podCreationTime">
4039
Running since {{ctrl.podCreationTime | date:'short'}}
4140
</span>
4241
<span ng-if="!ctrl.podCreationTime">
4342
Not running
4443
</span>
4544
</span>
46-
<span flex="auto" ></span>
47-
<md-button class="kd-icon-button" id="colorText"
48-
ng-click="ctrl.onTextColorChange()">
45+
46+
<span flex="auto"></span>
47+
<md-button ng-click="ctrl.onTextColorChange()">
48+
<md-icon md-font-library="material-icons"
49+
ng-class="ctrl.getStyleClass()">
50+
format_color_text
51+
</md-icon>
52+
</md-button>
53+
</div>
54+
55+
<div layout="row" hide-gt-sm layout-no-wrap layout-margin layout-align="center center"
56+
class="kd-logs-toolbar">
57+
<md-menu-bar class="kd-logs-toolbar-menu-bar">
58+
<md-menu>
59+
<button ng-click="$mdOpenMenu()" class="kd-logs-toolbar-menu-button">
60+
Logs source
61+
</button>
62+
<md-menu-content width="3">
63+
<md-menu-item>
64+
<md-menu>
65+
<md-button ng-click="$mdOpenMenu()">Pods</md-button>
66+
<md-menu-content width="4">
67+
<md-button ng-repeat="item in ctrl.pods"
68+
ng-click="ctrl.onPodChange(item.name)">{{item.name}}
69+
</md-button>
70+
</md-menu-content>
71+
</md-menu>
72+
</md-menu-item>
73+
<md-menu-item>
74+
<md-menu>
75+
<md-button ng-click="$mdOpenMenu()">Containers</md-button>
76+
<md-menu-content width="4">
77+
<md-button ng-repeat="item in ctrl.containers"
78+
ng-click="ctrl.onContainerChange(item.name)">{{item.name}}
79+
</md-button>
80+
</md-menu-content>
81+
</md-menu>
82+
</md-menu-item>
83+
</md-menu-content>
84+
</md-menu>
85+
</md-menu-bar>
86+
87+
<span flex="auto"></span>
88+
<md-button class="kd-logs-toolbar-icon" ng-click="ctrl.onTextColorChange()">
4989
<md-icon md-font-library="material-icons"
5090
ng-class="ctrl.getStyleClass()">
5191
format_color_text

src/app/frontend/logs/logstoolbar/logstoolbar.scss

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,3 +60,30 @@ md-toolbar {
6060
}
6161
}
6262
}
63+
64+
.md-button {
65+
&.kd-logs-toolbar-icon {
66+
min-width: 4 * $baseline-grid;
67+
}
68+
}
69+
70+
.kd-logs-toolbar-menu-button {
71+
color: $content-background;
72+
73+
&:after {
74+
content: '\25BC';
75+
display: inline-block;
76+
position: relative;
77+
transform: scaleY(.9) scaleX(1.3);
78+
}
79+
}
80+
81+
.kd-logs-toolbar-menu-bar {
82+
.kd-logs-toolbar-menu-button {
83+
background: none;
84+
}
85+
}
86+
87+
.kd-logs-toolbar {
88+
margin-bottom: $baseline-grid / 2;
89+
}

0 commit comments

Comments
 (0)