Skip to content

Commit d2267f9

Browse files
committed
Added missing ngInjects and updated breadcrumbs service
1 parent e0407a7 commit d2267f9

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

src/app/frontend/deploymentdetail/deploymentdetail_controller.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
export class DeploymentDetailController {
66
/**
77
* @param {!backendApi.DeploymentDetail} deploymentDetail
8+
* @ngInject
89
*/
910
constructor(deploymentDetail) {
1011
/** @export {!backendApi.DeploymentDetail} */

src/app/frontend/deploymentdetail/deploymentdetail_state.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
/** Name of the state. Can be used in, e.g., $state.go method. */
1616
export const stateName = 'deploymentdetail';
1717

18+
/** Absolute URL of the state. */
19+
export const stateUrl = '/api/v1/deployment/:namespace/:deployment';
20+
1821
/**
1922
* Parameters for this state.
2023
*

src/app/frontend/deploymentdetail/deploymentdetail_stateconfig.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@
1313
// limitations under the License.
1414

1515
import {actionbarViewName} from 'chrome/chrome_state';
16-
import {breadcrumbsConfig} from 'common/components/breadcrumbs/breadcrumbs_component';
16+
import {breadcrumbsConfig} from 'common/components/breadcrumbs/breadcrumbs_service';
1717
import {DeploymentDetailController} from './deploymentdetail_controller';
1818
import {stateName as deploymentList} from 'deploymentlist/deploymentlist_state';
19-
import {stateName} from './deploymentdetail_state';
19+
import {stateName, stateUrl} from './deploymentdetail_state';
2020

2121
/**
2222
* Configures states for the deployment detail view.
@@ -26,7 +26,7 @@ import {stateName} from './deploymentdetail_state';
2626
*/
2727
export default function stateConfig($stateProvider) {
2828
$stateProvider.state(stateName, {
29-
url: '/deployment/:namespace/:deployment',
29+
url: stateUrl,
3030
resolve: {
3131
'deploymentDetailResource': getDeploymentDetailResource,
3232
'deploymentDetail': getDeploymentDetail,
@@ -52,14 +52,16 @@ export default function stateConfig($stateProvider) {
5252
* @param {!./deploymentdetail_state.StateParams} $stateParams
5353
* @param {!angular.$resource} $resource
5454
* @return {!angular.Resource<!backendApi.DeploymentDetail>}
55+
* @ngInject
5556
*/
5657
export function getDeploymentDetailResource($resource, $stateParams) {
57-
return $resource(`api/v1/deployments/${$stateParams.namespace}/${$stateParams.deployment}`);
58+
return $resource(`api/v1/deployment/${$stateParams.namespace}/${$stateParams.deployment}`);
5859
}
5960

6061
/**
6162
* @param {!angular.Resource<!backendApi.DeploymentDetail>} deploymentDetailResource
6263
* @return {!angular.$q.Promise}
64+
* @ngInject
6365
*/
6466
export function getDeploymentDetail(deploymentDetailResource) {
6567
return deploymentDetailResource.get().$promise;

src/app/frontend/deploymentdetail/deploymentinfo_component.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export default class DeploymentInfoController {
1414
}
1515

1616
/**
17+
* Returns true if the deployment strategy is RollingUpdate
1718
* @return {boolean}
1819
* @export
1920
*/

0 commit comments

Comments
 (0)