Skip to content

[Helm Chart] Change Kong Pod annotations to work out-of-the-box with Kuma and Istio #10377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Helm Chart] Change Kong Pod annotations to work out-of-the-box with Kuma and Istio #10377

wants to merge 1 commit into from
+5 −0

Conversation

fuljo
Copy link

@fuljo fuljo commented Oct 6, 2025

The default Kong Chart we rely on sets these two annotations, by default, on its Pods.

Source: https://github.com/Kong/charts/blob/5c2eb33076061e90f49ac05c9b26e2b961a8bc4a/charts/kong/values.yaml#L986-L988

podAnnotations:
  kuma.io/gateway: enabled
  traffic.sidecar.istio.io/includeInboundPorts: ""

This prevents service meshes from correctly intercepting incoming traffic to the Kong Pod, for example when we want to expose the Dashboard using an Ingress or Gateway.
For more details, see #10376 .

This PR modifies the Kubernetes Dashboard's Chart default values to set these values as suggested in the Kong Proxy's Chart README, in the case we want to use it as an internal proxy rather than an external gateway (which is the default configuration).

kong:
  # Enable inbound mesh proxying for Kuma and Istio
  podAnnotations:
    kuma.io/gateway: disabled
    traffic.sidecar.istio.io/includeInboundPorts: "*"

@k8s-ci-robot k8s-ci-robot requested a review from floreks October 6, 2025 14:41
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fuljo
Once this PR has been reviewed and has the lgtm label, please assign floreks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @fuljo!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 6, 2025 •
edited
Loading

CLA Signed

  • ✅login: fuljo / name: Alessandro Fulgini / (b875c42)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks Awaiting requested review from floreks

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuljo @k8s-ci-robot