Skip to content

Commit 051d5e6

Browse files
committed
Address the PR comments
1 parent b75a493 commit 051d5e6

File tree

1 file changed

+9
-1
lines changed
  • keps/sig-windows/5100-windows-dsr-and-overlay-support

1 file changed

+9
-1
lines changed

keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,6 +459,9 @@ N/A - This feature is already implemented.
459459

460460
- 2 or more CNI solutions support overlay networking mode for Windows nodes.
461461

462+
1. [Calico networking](https://github.com/projectcalico/calico/blob/cf9455706a1fc6e9d5b11e4556f3d087007124e7/node/windows-packaging/CalicoWindows/kubernetes/kube-proxy-service.ps1#L65-L79) on Windows enables WinOverlay feature if the underlying HNS network is of type overlay.
463+
2. [Flannel](https://github.com/microsoft/SDN/blob/master/Kubernetes/flannel/start-kubeproxy.ps1#L19-L28) networking does the same.
464+
462465
<!--
463466
464467
**Note:** Generally we also wait at least two releases between beta and
@@ -616,6 +619,11 @@ For DSR, kube-proxy should resync HNS rules and start using DSR again.
616619

617620
###### Are there any tests for feature enablement/disablement?
618621

622+
We have periodic test passes running in prow that use both of these configurations
623+
624+
- [capz-windows-master-containerd2](https://testgrid.k8s.io/sig-windows-signal#capz-windows-master-containerd2) all of the Windows CAPZ tests use calico by default.
625+
- [ltsc2025-containerd-flannel-sdnoverlay-master](https://testgrid.k8s.io/sig-windows-networking#ltsc2025-containerd-flannel-sdnoverlay-master) for flannel with overlay networking mode.
626+
619627
<!--
620628
The e2e framework does not currently support enabling or disabling feature
621629
gates. However, unit tests in each component dealing with managing data, created
@@ -967,7 +975,7 @@ We have not observed any additional failure modes with DSR or overlay networking
967975

968976
###### What steps should be taken if SLOs are not being met to determine the problem?
969977

970-
N/A
978+
See [Troubleshooting](#troubleshooting)
971979

972980
## Implementation History
973981

0 commit comments

Comments
 (0)