Skip to content

Commit 0521f88

Browse files
committed
review feedback (part 2)
Signed-off-by: Anish Ramasekar <[email protected]>
1 parent 6f97ea1 commit 0521f88

File tree

1 file changed

+12
-0
lines changed
  • keps/sig-auth/4412-projected-service-account-tokens-for-kubelet-image-credential-providers

1 file changed

+12
-0
lines changed

keps/sig-auth/4412-projected-service-account-tokens-for-kubelet-image-credential-providers/README.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -898,6 +898,16 @@ well as the [existing list] of feature gates.
898898
- Feature gate name: `ServiceAccountNodeAudienceRestriction`
899899
- Components depending on the feature gate: kube-apiserver
900900

901+
The purpose of the two feature gates is different, which is why they weren't named similarly.
902+
903+
The `KubeletServiceAccountTokenForCredentialProviders` feature gate is used to enable the kubelet to use service account tokens for image pull in the kubelet credential provider.
904+
905+
The `ServiceAccountNodeAudienceRestriction` feature gate is used to enable the kube-apiserver to validate the audience of the service account token requested by the kubelet. The feature gate in the Kubernetes API Server (KAS) was introduced to strictly enforce which audiences the kubelet can request tokens for. Before this change, the kubelet could request a token with any audience. With the feature gate enabled, the API server starts validating the requested audience.
906+
907+
The KAS feature gate doesn't need to be enabled for the kubelet feature to work. It graduated to beta in v1.32 and is enabled by default. The two are unrelated in functionality, but the KAS gate was necessary to ensure strict enforcement of the allowed audiences the kubelet can request tokens for.
908+
909+
If the KAS feature gate is not enabled, there will be no validation of the audience requested by the kubelet, and the kubelet will be able to request tokens for any audience. This is not recommended.
910+
901911
###### Does enabling the feature change any default behavior?
902912

903913
<!--
@@ -1040,6 +1050,8 @@ Users can observe events for successful image pulls that use the service account
10401050
- [x] Events
10411051
- Event Reason: " Successfully pulled image "xxx" in 11.877s (11.877s including waiting). Image size: xxx bytes."
10421052

1053+
For registries or images configured to be pulled using a credential provider with a service account, a successful image pull seems to be the only way to confirm that it's working. If the credential provider is misbehaving, the kubelet will not be able to authenticate to the registry and pull images, which will result in image pull errors.
1054+
10431055
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
10441056

10451057
<!--

0 commit comments

Comments
 (0)