Skip to content

Commit 05eed6d

Browse files
committed
add metric scheduler_plugin_execution_duration_seconds{plugin="SchedulingGates"}
1 parent eae4e6c commit 05eed6d

File tree

1 file changed

+8
-0
lines changed
  • keps/sig-scheduling/3521-pod-scheduling-readiness

1 file changed

+8
-0
lines changed

keps/sig-scheduling/3521-pod-scheduling-readiness/README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -801,6 +801,9 @@ A rollback might be considered if the metric `scheduler_pending_pods{queue="gate
801801
high watermark for a long time. It, if not intentionally, may reveal that some controllers forget
802802
to empty the Pods' scheduling gates, which keep them in pending state.
803803

804+
Another indicator for rollback is the 90-percentile value of metric `scheduler_plugin_execution_duration_seconds{plugin="SchedulingGates"}`
805+
exceeds 100ms steadily.
806+
804807
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
805808

806809
<!--
@@ -836,6 +839,9 @@ Node to host the Pod
836839
- `scheduler_pending_pods{queue="gated"}` (new): scheduler respect the Pod's present `schedulingGates`
837840
and hence not schedule it
838841

842+
The metric `scheduler_plugin_execution_duration_seconds{plugin="SchedulingGates"}` gives a histogram
843+
to show the Nth percentile value how SchedulingGates plugin is executed.
844+
839845
Moreover, to explicitly indicate a Pod's scheduling-unready state, a condition
840846
`{type:PodScheduled, reason:SchedulingGated}` is introduced.
841847

@@ -848,6 +854,7 @@ logs or events for this purpose.
848854
-->
849855

850856
- observe non-zero value for the metric `pending_pods{queue="gated"}`
857+
- observe entries for the metric `scheduler_plugin_execution_duration_seconds{plugin="SchedulingGates"}`
851858
- observe non-empty value in a Pod's `.spec.schedulingGates` field
852859

853860
###### How can someone using this feature know that it is working for their instance?
@@ -901,6 +908,7 @@ Pick one more of these and delete the rest.
901908

902909
- [x] Metrics
903910
- Metric name: scheduler_pending_pods{queue="gated"}
911+
- Metric name: scheduler_plugin_execution_duration_seconds{plugin="SchedulingGates"}
904912
- Components exposing the metric: kube-scheduler
905913

906914
###### Are there any missing metrics that would be useful to have to improve observability of this feature?

0 commit comments

Comments
 (0)