Skip to content

Commit 070c386

Browse files
authored
Merge pull request #4173 from pacoxu/limit-image-pull
update kubelet parallel image pull limit for v1.29
2 parents b025cf7 + e38d101 commit 070c386

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

keps/sig-node/3673-kubelet-parallel-image-pull-limit/README.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ tags, and then generate with `hack/update-toc.sh`.
110110
- [Troubleshooting](#troubleshooting)
111111
- [Implementation History](#implementation-history)
112112
- [Alpha](#alpha-1)
113+
- [Beta](#beta-1)
113114
- [Drawbacks](#drawbacks)
114115
- [Alternatives](#alternatives)
115116
- [Infrastructure Needed (Optional)](#infrastructure-needed-optional)
@@ -381,8 +382,8 @@ https://storage.googleapis.com/k8s-triage/index.html
381382
We expect no non-infra related flakes in the last month as a GA graduation criteria.
382383
-->
383384

384-
A new node_e2e test with `serialize-image-pulls==false` will be added test parallel image pull limits.
385-
1. When maxParallelImagePulls is reached, all further image pulls will be blocked.
385+
A new node_e2e test with `serialize-image-pulls==false` will be added test parallel image pull limits.
386+
1. When maxParallelImagePulls is reached, all further image pulls will be blocked.
386387
2. Verify the behavior when the same image is pulled in parallel, which will happen when image pull policy is `Always`.
387388

388389
- <test>: <link to test coverage>
@@ -905,7 +906,15 @@ Major milestones might include:
905906

906907
### Alpha
907908

908-
Alpha feature was implemented in 1.27.
909+
Alpha feature was implemented in 1.27: <https://github.com/kubernetes/kubernetes/pull/115220>
910+
911+
### Beta
912+
913+
Add e2e tests(WIP):
914+
915+
1. A new node_e2e test to confirm image pull will be blocked if maxParallelImagePulls is reached.
916+
2. Verfiy behavior of image pull in parallel for same image using `imagePullPolicy:Always`.
917+
3. Check the waiting period of image pull for pods with `MaxParallelImagePulls: 1` and `MaxParallelImagePulls: 5`.
909918

910919
## Drawbacks
911920

keps/sig-node/3673-kubelet-parallel-image-pull-limit/kep.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ authors:
66
owning-sig: sig-node
77
status: implementable
88
creation-date: 2023-01-05
9+
last-updated: 2023-09-08
910
reviewers:
1011
- "@SergeyKanzhelev"
1112
approvers:
@@ -17,10 +18,10 @@ stage: beta
1718
# The most recent milestone for which work toward delivery of this KEP has been
1819
# done. This can be the current (upcoming) milestone, if it is being actively
1920
# worked on.
20-
latest-milestone: "v1.28"
21+
latest-milestone: "v1.29"
2122

2223
# The milestone at which this feature was, or is targeted to be, at each stage.
2324
milestone:
2425
alpha: "v1.27"
25-
beta: "v1.28"
26-
stable: "v1.29"
26+
beta: "v1.29"
27+
stable: "v1.30"

0 commit comments

Comments
 (0)