Skip to content

Commit 0926385

Browse files
committed
KEP-3221: update metric label/value
1 parent f56ca62 commit 0926385

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

keps/sig-auth/3221-structured-authorization-configuration/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -480,11 +480,11 @@ It will track total invocation counts across the following labels.
480480

481481
- `name` {<authorizer_name>}
482482
- value matches the configuration `name` field
483-
- `code` {canceled, timeout, error, ok}
483+
- `result` {canceled, timeout, error, success}
484484
- `canceled`: the call invoking the webhook request was canceled
485485
- `timeout`: the webhook request timed out
486486
- `error`: the webhook response completed and was invalid
487-
- `ok`: the webhook response completed and was well-formed
487+
- `success`: the webhook response completed and was well-formed
488488

489489
3. `apiserver_authorization_webhook_duration_seconds`
490490

@@ -493,11 +493,11 @@ This is a Histogram metric that will track the total round trip time of the requ
493493
Labels {along with possible values}:
494494
- `name` {<authorizer_name>}
495495
- value matches the configuration `name` field
496-
- `code` {canceled, timeout, error, ok}
496+
- `result` {canceled, timeout, error, success}
497497
- `canceled`: the call invoking the webhook request was canceled
498498
- `timeout`: the webhook request timed out
499499
- `error`: the webhook response completed and was invalid
500-
- `ok`: the webhook response completed and was well-formed
500+
- `success`: the webhook response completed and was well-formed
501501

502502
4. `apiserver_authorization_webhook_evaluations_fail_open_total`
503503

@@ -508,7 +508,7 @@ Labels {along with possible values}:
508508

509509
- `name` {<authorizer_name>}
510510
- value matches the configuration `name` field
511-
- `code` {timeout, error}
511+
- `result` {timeout, error}
512512
- `timeout`: the webhook request timed out
513513
- `error`: the webhook response completed and was invalid
514514

keps/sig-auth/3221-structured-authorization-configuration/kep.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ feature-gates:
2828
disable-supported: true
2929
metrics:
3030
- apiserver_authorization_decisions_total{type, name, decision}
31-
- apiserver_authorization_webhook_duration_seconds{name, code}
32-
- apiserver_authorization_webhook_evaluations_total{name, code}
33-
- apiserver_authorization_webhook_evaluations_fail_open_total{name, code}
31+
- apiserver_authorization_webhook_duration_seconds{name, result}
32+
- apiserver_authorization_webhook_evaluations_total{name, result}
33+
- apiserver_authorization_webhook_evaluations_fail_open_total{name, result}
3434
- apiserver_authorization_config_controller_automatic_reload_last_timestamp_seconds{apiserver_id_hash, status}
3535
- apiserver_authorization_config_controller_automatic_reloads_total{apiserver_id_hash, status}
3636
- apiserver_authorization_match_condition_evaluation_errors_total{type, name}

0 commit comments

Comments
 (0)