Skip to content

Commit 0bb74a9

Browse files
authored
Merge pull request #5077 from pohly/kep-template-tests
KEP template: enhance suggestions for integration and e2e tests
2 parents 61abddc + 9f589f6 commit 0bb74a9

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

keps/NNNN-kep-template/README.md

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -308,31 +308,43 @@ Integration tests are contained in k8s.io/kubernetes/test/integration.
308308
Integration tests allow control of the configuration parameters used to start the binaries under test.
309309
This is different from e2e tests which do not allow configuration of parameters.
310310
Doing this allows testing non-default options and multiple different and potentially conflicting command line options.
311+
For more details, see https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/testing-strategy.md
312+
313+
If integration tests are not necessary or useful, explain why.
311314
-->
312315

313316
<!--
314317
This question should be filled when targeting a release.
315318
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
316319
317-
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
318-
https://storage.googleapis.com/k8s-triage/index.html
320+
For Beta and GA, document that tests have been written,
321+
have been executed regularly, and have been stable.
322+
This can be done with:
323+
- permalinks to the GitHub source code
324+
- links to the periodic job (typically https://testgrid.k8s.io/sig-release-master-blocking#integration-master), filtered by the test name
325+
- a search in the Kubernetes bug triage tool (https://storage.googleapis.com/k8s-triage/index.html)
319326
-->
320327

321-
- <test>: <link to test coverage>
328+
- [test name](https://github.com/kubernetes/kubernetes/blob/2334b8469e1983c525c0c6382125710093a25883/test/integration/...): [integration master](https://testgrid.k8s.io/sig-release-master-blocking#integration-master?include-filter-by-regex=MyCoolFeature), [triage search](https://storage.googleapis.com/k8s-triage/index.html?test=MyCoolFeature)
322329

323330
##### e2e tests
324331

325332
<!--
326333
This question should be filled when targeting a release.
327334
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
328335
329-
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
330-
https://storage.googleapis.com/k8s-triage/index.html
336+
For Beta and GA, document that tests have been written,
337+
have been executed regularly, and have been stable.
338+
This can be done with:
339+
- permalinks to the GitHub source code
340+
- links to the periodic job (typically a job owned by the SIG responsible for the feature), filtered by the test name
341+
- a search in the Kubernetes bug triage tool (https://storage.googleapis.com/k8s-triage/index.html)
331342
332343
We expect no non-infra related flakes in the last month as a GA graduation criteria.
344+
If e2e tests are not necessary or useful, explain why.
333345
-->
334346

335-
- <test>: <link to test coverage>
347+
- [test name](https://github.com/kubernetes/kubernetes/blob/2334b8469e1983c525c0c6382125710093a25883/test/e2e/...): [SIG ...](https://testgrid.k8s.io/sig-...?include-filter-by-regex=MyCoolFeature), [triage search](https://storage.googleapis.com/k8s-triage/index.html?test=MyCoolFeature)
336348

337349
### Graduation Criteria
338350

0 commit comments

Comments
 (0)