Skip to content

Commit 0dea904

Browse files
committed
node: KEP-2902: Capture plans of metric addition for Beta graduation
Signed-off-by: Swati Sehgal <[email protected]>
1 parent 8f8608f commit 0dea904

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

keps/sig-node/2902-cpumanager-distribute-cpus-policy-option/README.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,8 @@ No changes. Existing container will not see their allocation changed. New contai
221221

222222
###### What specific metrics should inform a rollback?
223223

224-
Not Applicable.
224+
As part of graduation of this feature, we plan to add metric `cpu_manager_numa_allocation_spread` to see how the CPUs are distributed across NUMA nodes.
225+
This can be used to see the CPU distribution across NUMA and will provide an indication of a rollback.
225226

226227
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
227228

@@ -238,6 +239,8 @@ No
238239

239240
Inspect the kubelet configuration of a node -- check for the presence of the feature gate and usage of the new policy option.
240241

242+
In addition to that, we can check the metric `cpu_manager_numa_allocation_spread` to determine how allocated CPUs are spread across NUMA node.
243+
241244
###### How can someone using this feature know that it is working for their instance?
242245

243246
In order to verify this feature is working, one should:
@@ -251,6 +254,8 @@ To verify the list of CPUs allocated to the container, one can either:
251254
- `exec` into uthe container and run `taskset -cp 1` (assuming this command is available in the container).
252255
- Call the `GetCPUS()` method of the `CPUProvider` interface in the `kubelet`'s [podresources API](https://pkg.go.dev/k8s.io/kubernetes/pkg/kubelet/apis/podresources#CPUsProvider).
253256

257+
Also, we can check `cpu_manager_numa_allocation_spread` metric.
258+
254259
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
255260

256261
There are no specific SLOs for this feature.
@@ -262,7 +267,8 @@ None
262267

263268
###### Are there any missing metrics that would be useful to have to improve observability of this feature?
264269

265-
None
270+
Yes, as part of graduation of this feature to Beta, we plan to add `cpu_manager_numa_allocation_spread` metric
271+
to provide data on how the CPUs are distributed across NUMA nodes.
266272

267273
###### Does this feature depend on any specific services running in the cluster?
268274

keps/sig-node/2902-cpumanager-distribute-cpus-policy-option/kep.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,5 @@ feature-gates:
4646
disable-supported: true
4747

4848
# The following PRR answers are required at beta release
49-
metrics: []
49+
metrics:
50+
- cpu_manager_numa_allocation_spread

0 commit comments

Comments
 (0)