Skip to content

Commit 1590be9

Browse files
committed
KEP-3221: add PRR review, adjust metrics
1 parent 75497ab commit 1590be9

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
kep-number: 3221
22
alpha:
33
approver: "@deads2k"
4+
beta:
5+
approver: "@jpbetz"

keps/sig-auth/3221-structured-authorization-configuration/README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -501,13 +501,15 @@ Labels {along with possible values}:
501501

502502
5. `apiserver_authorization_config_controller_automatic_reload_last_timestamp_seconds`
503503

504-
This Gauge metric will record last time in seconds when an authorization reload was performed, partitioned by apiserver_id_hash.
504+
This Gauge metric will record last time in seconds when an authorization reload was performed, partitioned by apiserver_id_hash and status.
505505
- `apiserver_id_hash`
506+
- `status` (`success` or `failure`)
506507

507-
6. `apiserver_authorization_config_controller_automatic_reload_failures_total` and `apiserver_authorization_config_controller_automatic_reload_success_total`
508+
6. `apiserver_authorization_config_controller_automatic_reloads_total`
508509

509-
These Counter metrics record the total number of reload successes and failures, partitioned by API server apiserver_id_hash.
510+
This Counter metric records the total number of reload successes and failures, partitioned by API server apiserver_id_hash and status.
510511
- `apiserver_id_hash`
512+
- `status` (`success` or `failure`)
511513

512514
### Test Plan
513515

keps/sig-auth/3221-structured-authorization-configuration/kep.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,4 @@ feature-gates:
2828
disable-supported: true
2929
metrics:
3030
- apiserver_authorization_config_controller_automatic_reload_last_timestamp_seconds
31-
- apiserver_authorization_config_controller_automatic_reload_success_total{apiserver_id_hash}
32-
- apiserver_authorization_config_controller_automatic_reload_failures_total{apiserver_id_hash}
31+
- apiserver_authorization_config_controller_automatic_reloads_total{apiserver_id_hash, type}

0 commit comments

Comments
 (0)