Skip to content

Commit 15943ca

Browse files
authored
Merge pull request #4544 from adrianreber/2024-03-08-beta
KEP 2008: Update KEP to reflect current code changes
2 parents 3fed55c + 3b11bdb commit 15943ca

File tree

1 file changed

+9
-9
lines changed
  • keps/sig-node/2008-forensic-container-checkpointing

1 file changed

+9
-9
lines changed

keps/sig-node/2008-forensic-container-checkpointing/README.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -374,26 +374,26 @@ At least one container engine implemented the corresponding CRI APIs:
374374
In Kubernetes:
375375

376376
- [x] No major bugs reported in the previous cycle
377-
- [ ] Enable the feature per default
378-
- [ ] Add separate sub-resource permission to control permissions
377+
- [x] Enable the feature per default
378+
- [x] Add separate sub-resource permission to control permissions
379379
at <https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/server/auth.go#L101-L108>
380-
- [ ] Add necessary metrics as described in the PRR sections and update the KEP with the metrics
380+
- [x] Add necessary metrics as described in the PRR sections and update the KEP with the metrics
381381
names once they exist
382-
- [ ] Add CRI metrics
383-
- [ ] Add kubelet metrics (this already exist under the name `checkpoint`)
382+
- [x] Add CRI metrics (this already exists via `kubelet_runtime_operations_errors_total`)
383+
- [x] Add kubelet metrics (this already exists under the name `checkpoint`)
384384
<https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/server/server.go#L442>
385385

386386
#### Beta to GA Graduation
387387

388388
CRI-O as well as containerd have to have implemented the corresponding CRI APIs:
389389

390390
- [x] CRI-O
391-
- [ ] containerd (<https://github.com/containerd/containerd/pull/6965>)
391+
- [x] containerd (<https://github.com/containerd/containerd/pull/6965>)
392392

393393
Ensure that e2e tests are working with
394394

395395
- [x] CRI-O
396-
- [ ] containerd (<https://github.com/containerd/containerd/pull/6965>)
396+
- [x] containerd (<https://github.com/containerd/containerd/pull/6965>)
397397

398398
### Upgrade / Downgrade Strategy
399399

@@ -457,8 +457,8 @@ request will fail.
457457

458458
###### What specific metrics should inform a rollback?
459459

460-
CRI metrics will be added to track checkpointing failures to inform a rollback
461-
decision.
460+
It is possible to query the number of failed checkpoint operations using the
461+
*kubelet* metrics API endpoint `kubelet_runtime_operations_errors_total`.
462462

463463
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
464464

0 commit comments

Comments
 (0)