Skip to content

Commit 15c3c95

Browse files
committed
Address comments
1 parent 3dd6372 commit 15c3c95

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

keps/prod-readiness/sig-node/5394.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
# of http://git.k8s.io/enhancements/OWNERS_ALIASES
44
kep-number: 5394
55
alpha:
6-
approver: "@johnbelamaric"
6+
approver: "@soltysh"

keps/sig-node/5394-psi-node-conditions/README.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -266,12 +266,15 @@ it.
266266

267267
#### Deprecation
268268

269+
<!--
269270
- Announce deprecation and support policy of the existing flag
270271
- Two versions passed since introducing the functionality that deprecates the flag (to address version skew)
271272
- Address feedback on usage/changed behavior, provided on GitHub issues
272273
- Deprecate the flag
273274
-->
274275

276+
N/A
277+
275278
### Upgrade / Downgrade Strategy
276279

277280
No impact. Runc will be upgraded to 1.2.0 version as a prerequisite for this feature,
@@ -283,9 +286,6 @@ to a different kubelet version.
283286

284287
N/A
285288

286-
PSI stats will be available only after CRI and cadvisor have been updated to use runc 1.2.0
287-
in K8s 1.29. Since `PSI Based Node Conditions` is dependent on kubelet version, and CRI and kubelet are generally updated in tandem, Version skew strategy is not applicable.
288-
289289
## Production Readiness Review Questionnaire
290290

291291
<!--
@@ -344,7 +344,9 @@ well as the [existing list] of feature gates.
344344
Any change of default behavior may be surprising to users or break existing
345345
automations, so be extremely careful here.
346346
-->
347-
TBD
347+
No behavior change when there is no node level resource pressure.
348+
349+
When there is node level memory / IO pressure, the node will be marked with the corresponding resource pressure condition and taint, which will prevent new workloads from being scheduled to this node.
348350

349351
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
350352

@@ -516,7 +518,7 @@ and creating new ones, as well as about cluster-level services (e.g. DNS):
516518
- Impact of its outage on the feature:
517519
- Impact of its degraded performance or high-error rates on the feature:
518520
-->
519-
Yes, it depends on runc version 1.2.0. This KEP can be implemented only after runc 1.2.0 is released, which is estimated to be released in Q1 2024.
521+
N/A
520522

521523
### Scalability
522524

keps/sig-node/5394-psi-node-conditions/kep.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ authors:
77
owning-sig: sig-node
88
participating-sigs:
99
- sig-node
10+
- sig-scheduling
1011
status: implementable
1112
creation-date: 2025-06-11
1213
reviewers:

0 commit comments

Comments
 (0)