Skip to content

Commit 1dc558b

Browse files
committed
Add more detail to the PRR
Signed-off-by: Sascha Grunert <[email protected]>
1 parent d0908f6 commit 1dc558b

File tree

1 file changed

+9
-1
lines changed
  • keps/sig-node/4639-oci-volume-source

1 file changed

+9
-1
lines changed

keps/sig-node/4639-oci-volume-source/README.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,9 +655,17 @@ NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
655655
Yes, by disabling the feature gate. Existing workloads will not be affected by
656656
the change.
657657

658+
To clear old volumes, all workloads using the `VolumeSource` needs to be
659+
recreated after restarting the kubelets. The kube-apiserver does only the API
660+
validation whereas the kubelets serve the implementation. This means means that
661+
a restart of the kubelet as well as the workload would be enough to disable the
662+
feature functionality.
663+
658664
###### What happens if we reenable the feature if it was previously rolled back?
659665

660-
It will make the API functional again.
666+
It will make the API functional again. If the feature gets re-enabled only for a
667+
subset of kubelets and a user runs a scalable deployment or daemonset, then the
668+
volume source will be only available for some pod instances.
661669

662670
###### Are there any tests for feature enablement/disablement?
663671

0 commit comments

Comments
 (0)