Skip to content

Commit 220604e

Browse files
authored
crashloopbackoff.max -> crashloopbackoff.maxSeconds
1 parent 1515af5 commit 220604e

File tree

1 file changed

+7
-7
lines changed
  • keps/sig-node/4603-tune-crashloopbackoff

1 file changed

+7
-7
lines changed

keps/sig-node/4603-tune-crashloopbackoff/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ its expedient to see the exact config proposed here:
411411
apiVersion: kubelet.config.k8s.io/v1beta1
412412
kind: KubeletConfiguration
413413
crashloopbackoff:
414-
max: 4
414+
maxSeconds: 4
415415
```
416416

417417
### Refactor and flat rate to 10 minutes for the backoff counter reset threshold
@@ -760,7 +760,7 @@ The proposed configuration explicitly looks like this:
760760
apiVersion: kubelet.config.k8s.io/v1beta1
761761
kind: KubeletConfiguration
762762
crashloopbackoff:
763-
max: 4
763+
maxSeconds: 4
764764
```
765765

766766
### Refactor of recovery threshold
@@ -1146,7 +1146,7 @@ heterogenity between "Succeeded" terminating pods, and crashing pods whose
11461146

11471147
#### Alpha
11481148

1149-
- New `int32 crashloopbackoff.max` field in `KubeletConfiguration` API, validated
1149+
- New `int32 crashloopbackoff.maxSeconds` field in `KubeletConfiguration` API, validated
11501150
to a minimum of 1 and a maximum of 300, used when
11511151
`EnableKubeletCrashLoopBackoffMax` feature flag enabled, to customize
11521152
CrashLoopBackOff per node
@@ -1300,12 +1300,12 @@ To make use of this enhancement, on cluster upgrade, the
13001300
`EnableKubeletCrashLoopBackoffMax` feature gate must first be turned on for the
13011301
cluster. Then, if any nodes need to use a different backoff curve, their kubelet
13021302
must be completely redeployed either in the same upgrade or after that upgrade
1303-
with the `crashloopbackoff.max` `KubeletConfiguration` set.
1303+
with the `crashloopbackoff.maxSeconds` `KubeletConfiguration` set.
13041304

13051305
To stop use of this enhancement, there are two options.
13061306

13071307
On a per-node basis, nodes can be completely redeployed with
1308-
`crashloopbackoff.max` `KubeletConfiguration` unset. Since kubelet does
1308+
`crashloopbackoff.maxSeconds` `KubeletConfiguration` unset. Since kubelet does
13091309
not cache the backoff object, on kubelet restart they will start from the
13101310
beginning of their backoff curve (either the original one with initial value
13111311
10s, or the new baseline with initial value 1s, depending on whether they've
@@ -1343,9 +1343,9 @@ lower than 300s, it will be honored. In other words, operator-invoked
13431343
configuration will have precedence over the default, even if it is slower, as
13441344
long as it is valid.
13451345

1346-
If `crashloopbackoff.max` `KubeletConfiguration` exists but
1346+
If `crashloopbackoff.maxSeconds` `KubeletConfiguration` exists but
13471347
`EnableKubeletCrashLoopBackoffMax` is off, kubelet will log a warning but will
1348-
not honor the `crashloopbackoff.max` `KubeletConfiguration`. In other words,
1348+
not honor the `crashloopbackoff.maxSeconds` `KubeletConfiguration`. In other words,
13491349
operator-invoked per node configuration will not be honored if the overall
13501350
feature gate is turned off.
13511351

0 commit comments

Comments
 (0)