Skip to content

Commit 2263fb4

Browse files
marquizhaircommander
authored andcommitted
KEP-4033: address review feedback from sftim
- reword tell -> instruct - fix SIG-Node -> SIG Node
1 parent b987c4d commit 2263fb4

File tree

1 file changed

+4
-4
lines changed
  • keps/sig-node/4033-group-driver-detection-over-cri

1 file changed

+4
-4
lines changed

keps/sig-node/4033-group-driver-detection-over-cri/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
156156

157157
## Summary
158158

159-
This enhancement adds the ability for the container runtime to tell kubelet
159+
This enhancement adds the ability for the container runtime to instruct kubelet
160160
which cgroup driver to use. This removes the need for specifying cgroup driver
161161
in the kubelet configuration and eliminates the possibility of misaligned
162162
cgroup driver configuration between the kubelet and the runtime.
@@ -216,7 +216,7 @@ This might be a good place to talk about core concepts and how they relate.
216216
### Risks and Mitigations
217217

218218
Field adoption could be considered a risk, though the CRI implementations work
219-
closely with SIG-Node and the feature will move along with CRI implementation
219+
closely with SIG Node and the feature will move along with CRI implementation
220220
adoption.
221221

222222
## Design Details
@@ -502,7 +502,7 @@ well as the [existing list] of feature gates.
502502
[existing list]: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/
503503
-->
504504

505-
No feature gate required–the fields are all SIG-Node internal and have simple
505+
No feature gate required–the fields are all SIG Node internal and have simple
506506
fallbacks.
507507

508508
###### Does enabling the feature change any default behavior?
@@ -877,7 +877,7 @@ Make kubelet the configuration point for cgroup driver so that kubelet would
877877
inform the runtime which cgroup driver to use. This could be achieved e.g.
878878
without any changes to the CRI API by the CRI implementation guessing the
879879
cgroup driver based on the path of the CgroupParent of the pod, passed down in
880-
the RunPodSandboxRequest. However, SIG-Node has decided that the CRI
880+
the RunPodSandboxRequest. However, SIG Node has decided that the CRI
881881
implementation should begin to be the source of truth for low-level choices
882882
like this, and thus this approach was chosen.
883883

0 commit comments

Comments
 (0)