Skip to content

Commit 22d2875

Browse files
committed
Update "Implementation History"
Co-authored-by: Dominik Marciński <[email protected]>
1 parent fd1bd80 commit 22d2875

File tree

1 file changed

+3
-6
lines changed
  • keps/sig-scheduling/5007-device-attach-before-pod-scheduled

1 file changed

+3
-6
lines changed

keps/sig-scheduling/5007-device-attach-before-pod-scheduled/README.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -546,9 +546,9 @@ type DeviceRequestAllocationResult struct {
546546

547547
When `UsageRestrictedToNode: true` is set, the scheduler DRA plugin will perform the following steps:
548548

549-
1. **Set NodeSelector in api-server**: Before the `PreBind` phase, add the `NodeName` to the `ResourceClaim`'s `NodeSelector`.
549+
1. **Set NodeSelector in api-server**: During the `PreBind` phase, propagate the `NodeName` to the `ResourceClaim`'s `NodeSelector` to the api-server.
550550

551-
If Conditions are present, the scheduler DRA plugin will perform the following steps during the `PreBind` phase:
551+
If Conditions are present, the scheduler DRA plugin will additionally perform the following steps:
552552

553553
2. **Copy Conditions**: Copy `UsageRestrictedToNode`, `BindingTimeout`, `BindingConditions` and `BindingFailureConditions` from `ResourceSlice.Device.Basic` to `DeviceRequestAllocationResult`.
554554
3. **Wait for Conditions**: Wait for the following conditions:
@@ -703,7 +703,6 @@ This can inform certain test coverage improvements that we want to do before
703703
extending the production code to implement this enhancement.
704704
-->
705705

706-
- `<package>`: `<date>` - `<test coverage>`
707706
- `k8s.io/kubernetes/pkg/scheduler/framework/plugins/dynamicresources`: `2025-05-26` - `79.3`
708707
- `k8s.io/dynamic-resource-allocation/resourceclaim`: `2025-05-26` : `90.9`
709708
- `k8s.io/dynamic-resource-allocation/resourceslice`: `2025-05-26` : `75.3`
@@ -726,8 +725,6 @@ For Beta and GA, add links to added tests together with links to k8s-triage for
726725
https://storage.googleapis.com/k8s-triage/index.html
727726
-->
728727

729-
- <test>: <link to test coverage>
730-
731728
- Simulate a controller updating ResourceClaim conditions
732729
- Verify scheduler behavior on success, failure, and timeout
733730
- Simulate multiple Pods referencing the same ResourceClaim with BindingConditions to verify the scheduler's behavior during the PreBind phase.
@@ -1177,7 +1174,7 @@ Major milestones might include:
11771174
- 2024-12: Initial proposal drafted and discussed in SIG scheduling, WG device management.
11781175
- 2025-03: KEP revised to introduce BindingConditions as a general mechanism.
11791176
- 2025-05: Updated KEP submitted for review.
1180-
1177+
- 2025-06: Improve some API descriptions, and clarify that "fail and reschedule" is an anti-pattern.
11811178

11821179
## Drawbacks
11831180

0 commit comments

Comments
 (0)