Skip to content

Commit 23c4ff1

Browse files
jm-francpr00se
andcommitted
Improve the section dedicated to risks.
Co-authored-by: Patryk Prus <[email protected]>
1 parent 566e097 commit 23c4ff1

File tree

1 file changed

+4
-5
lines changed
  • keps/sig-autoscaling/4951-configurable-hpa-tolerance

1 file changed

+4
-5
lines changed

keps/sig-autoscaling/4951-configurable-hpa-tolerance/README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -210,11 +210,10 @@ Since there are separate `HPAScalingRules` objects defined for an HPA's
210210

211211
### Risks and Mitigations
212212

213-
Risks are limited as this proposal does not introduce a new autoscaling parameters, but merely proposes to override an existing parameter for specific HPAs.
214-
215-
A user chosing an inapropriate value only impacts a unique Deployment. This allows users to experiment with different tolerance values before adopting those more widely.
216-
217-
A user disatisfied with the autoscaling behavior following an update of this parameter can fall back on the existing behavior by removing the new field.
213+
There should be minimal risk introduced by the proposed changes:
214+
- The new field is optional, and its absence results in no changes to the current autoscaling behavior
215+
- When specified, the new value doesn't change the autoscaling algorithm used, but just overrides a single value used during the calculation. This value can already be changed via the `--horizontal-pod-autoscaler-tolerance` option of the `kube-controller-manager`.
216+
- If a change to the new field results in undesirable behavior, the change can be reverted by deploying the previous version of the HPA resource, or removing the `tolerance` field entirely.
218217

219218
## Design Details
220219

0 commit comments

Comments
 (0)