Skip to content

Commit 24831fa

Browse files
committed
review feedback
1 parent ca1a000 commit 24831fa

File tree

1 file changed

+3
-24
lines changed
  • keps/sig-node/1287-in-place-update-pod-resources

1 file changed

+3
-24
lines changed

keps/sig-node/1287-in-place-update-pod-resources/README.md

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
- [Resource Quota](#resource-quota)
3939
- [Affected Components](#affected-components)
4040
- [Instrumentation](#instrumentation)
41-
- [<code>kubelet_pod_resize_requests_total</code>](#kubelet_pod_resize_requests_total)
4241
- [<code>kubelet_container_resize_requests_total</code>](#kubelet_container_resize_requests_total)
4342
- [<code>kubelet_pod_resize_sli_duration_seconds</code>](#kubelet_pod_resize_sli_duration_seconds)
4443
- [<code>kubelet_pod_infeasible_resize_total</code>](#kubelet_pod_infeasible_resize_total)
@@ -891,20 +890,6 @@ Other components:
891890

892891
The kubelet will record the following metrics:
893892

894-
#### `kubelet_pod_resize_requests_total`
895-
896-
This metric tracks the total number of resize requests observed by the Kubelet, counted at the pod level.
897-
A single pod update changing multiple containers will be considered a single resize request.
898-
899-
Labels:
900-
- `resource_type` - what type of resource is being resized. Possible values: `cpu_limits`, `cpu_requests` `memory_limits`, or `memory_requests`. If more than one of these resource types is changing in the resize request,
901-
we increment the counter multiple times, once for each. This means that a single pod update changing multiple
902-
resource types will be considered multiple requests for this metric.
903-
- `operation_type` - whether the resize is a net increase or a decrease (taken as an aggregate across
904-
all containers in the pod). Possible values: `increase`, `decrease`, `add`, or `remove`.
905-
906-
This metric is recorded as a counter.
907-
908893
#### `kubelet_container_resize_requests_total`
909894

910895
This metric tracks the total number of resize requests observed by the Kubelet, counted at the container level.
@@ -924,11 +909,6 @@ This metric tracks the latency between when the kubelet accepts a resize request
924909
the request. More precisely, this metric tracks the total amount of time that the `PodResizeInProgress` condition
925910
is present on a pod.
926911

927-
Labels:
928-
- `resource_type` - what type of resource is being resized. Possible values: `cpu_limits`, `cpu_requests` `memory_limits`, or `memory_requests`. If more than one of these resource types is changing in the resize request,
929-
we increment the counter multiple times, once for each.
930-
- `operation_type` - whether the resize is an increase or a decrease. Possible values: `increase`, `decrease`, `add`, or `remove`.
931-
932912
This metric is recorded as a gauge.
933913

934914
#### `kubelet_pod_infeasible_resize_total`
@@ -952,12 +932,11 @@ This metric is recorded as a counter.
952932
#### `kubelet_pod_deferred_resize_accepted_total`
953933

954934
This metric tracks the total number of resize requests that the Kubelet originally marked as deferred but
955-
later accepted. This metric primarily exists because if a deferred resize is accepted through the timed retry as
956-
opposed to being explicitly signaled, it indicates an issue in the Kubelet's logic for handling deferred
957-
resizes that we should fix.
935+
later accepted. This metric primarily exists because if a deferred resize is accepted through the timed retry (as
936+
opposed to being triggered by an event such as another pod being deleted or sized down), it indicates an issue in the Kubelet's logic for handling deferred resizes that we should fix.
958937

959938
Labels:
960-
- `retry_reason` - whether the resize was accepted through the timed retry or explicitly signaled. Possible values: `timed`, `signaled`.
939+
- `accepted_reason` - whether the resize was accepted through the timed retry or due to another pod event. Possible values: `periodic_retry`, `event_based`.
961940

962941
This metric is recorded as a counter.
963942

0 commit comments

Comments
 (0)